Fix timezone issues

Author: JoshuaBehrens

.github/workflows/build-test.yml

@@ -215,6 +215,8 @@ jobs:
             -   name: Install dependencies
                 run: |
                     brew install v8
+                    # Symlink icudtl.dat to the default location
+                    ln -sf /opt/homebrew/Cellar/v8/$(brew list --versions v8 | awk '{print $2}')/libexec/icudtl.dat /opt/homebrew/lib/icudtl.dat
 
             -   name: Build extension
                 run: |

README.Linux.md

@@ -96,16 +96,18 @@ cd v8
 git checkout 12.0.267.36
 gclient sync -D
 
+ARCH=$(uname -m)
+
 # Setup GN
-tools/dev/v8gen.py -vv x64.release -- is_component_build=true use_custom_libcxx=false
+tools/dev/v8gen.py -vv ${ARCH}.release -- is_component_build=true use_custom_libcxx=false
 
 # Build
-ninja -C out.gn/x64.release/
+ninja -C out.gn/${ARCH}.release/
 
 # Install to /opt/v8/
 sudo mkdir -p /opt/v8/{lib,include}
-sudo cp out.gn/x64.release/lib*.so out.gn/x64.release/*_blob.bin \
-  out.gn/x64.release/icudtl.dat /opt/v8/lib/
+sudo cp out.gn/${ARCH}.release/lib*.so out.gn/${ARCH}.release/*_blob.bin \
+  out.gn/${ARCH}.release/icudtl.dat /opt/v8/lib/
 sudo cp -R include/* /opt/v8/include/
 ```
 

README.MacOS.md

@@ -21,3 +21,19 @@ make -j4
 make test
 make install
 ```
+
+V8Js' build system assumes that the `icudtl.dat` file is located next to the `libv8.so`
+library file and compiles the path into the library itself.  If for whatever reason the
+`icudtl.dat` file is stored at a different place during runtime, you need to set the
+php.ini variable `v8js.icudtl_dat_path` to point to the file.  Otherwise locale-aware
+features of V8 will not work as expected.
+
+To avoid having to configure `v8js.icudtl_dat_path` manually, you can symlink or copy the ICU data file into the default library location. For Homebrew users, run:
+
+In case of a brew installed v8, run:
+
+```
+ln -sf /opt/homebrew/Cellar/v8/$(brew list --versions v8 | awk '{print $2}')/libexec/icudtl.dat /opt/homebrew/lib/icudtl.dat
+```
+
+This ensures V8Js will find `icudtl.dat` automatically and timezone/i18n support will work out of the box.