False positive `Dynamic call to static method` when mixing in another class and implementing `__call` and `__callStatic`

[msbit]

When you've a class Foo that:

• provides implementations of both __call and __callStatic, and
• mixes in another class Bar that has an instance method bar

creating an instance of Foo and calling that instance method results in an error of the form:

Dynamic call to static method Bar::bar(). [identifier=staticMethod.dynamicCall]

Playground: https://phpstan.org/r/bfd29cdb-749b-4b97-bd50-92ecb0fcfc92

Thanks!

[msbit]

Looking over the main repo, I see the following issues that were resolved around this space:

phpstan/phpstan#3641
phpstan/phpstan#5536

With a common mixed in class defined as follows:

class MixedIn
{
  function method(): void {}
}

The first reported false positives with the following:

/** @mixin MixedIn */
class Mixer
{
  static function __callStatic(): void {}
}

Mixer::method();

the second false positives with this modified version:

/** @mixin MixedIn */
class Mixer
{
  function __call(): void {}

  static function __callStatic(): void {}
}

Mixer::method();

and what I'm reporting false positives with is a further modified version:

/** @mixin MixedIn */
class Mixer
{
  function __call(): void {}

  static function __callStatic(): void {}
}

(new Mixer)->method();

It's not clear to me whether DynamicCallOnStaticMethodsRule::processNode has enough information to operate properly at this point; nor even whether MixinMethodsClassReflectionExtension::findMethod does. It feels like somewhere along the line, either:

• asking for a method called Mixer::method could return two versions, one static and one dynamic, or
• the calling context (static/dynamic) could be passed to the method finding logic, so it can return the appropriate one