Implement UnaryMinusHandler

[staabm]

as in

• phpstan-src/src/Reflection/InitializerExprTypeResolver.php

  Lines 2523 to 2551 in 61b221c

  	public function getUnaryMinusType(Expr $expr, callable $getTypeCallback): Type
  	{
  	$type = $getTypeCallback($expr)->toNumber();
  	$scalarValues = $type->getConstantScalarValues();
  	if (count($scalarValues) > 0) {
  	$newTypes = [];
  	foreach ($scalarValues as $scalarValue) {
  	if (is_int($scalarValue)) {
  	/** @var int|float $newValue */
  	$newValue = -$scalarValue;
  	if (!is_int($newValue)) {
  	return $type;
  	}
  	$newTypes[] = new ConstantIntegerType($newValue);
  	} elseif (is_float($scalarValue)) {
  	$newTypes[] = new ConstantFloatType(-$scalarValue);
  	}
  	}
  	return TypeCombinator::union(...$newTypes);
  	}
  	if ($type instanceof IntegerRangeType) {
  	return $getTypeCallback(new Expr\BinaryOp\Mul($expr, new Int_(-1)));
  	}
  	return $type;
  	}

• phpstan-src/src/Analyser/NodeScopeResolver.php

  Lines 3626 to 3640 in 61b221c

  	} elseif (
  	$expr instanceof Expr\BitwiseNot
  	|| $expr instanceof Cast
  	|| $expr instanceof Expr\Clone_
  	|| $expr instanceof Expr\UnaryMinus
  	|| $expr instanceof Expr\UnaryPlus
  	) {
  	$result = $this->processExprNode($stmt, $expr->expr, $scope, $nodeCallback, $context->enterDeep());
  	$throwPoints = $result->getThrowPoints();
  	$impurePoints = $result->getImpurePoints();
  	$isAlwaysTerminating = $result->isAlwaysTerminating();
  	$hasYield = $result->hasYield();
  	$scope = $result->getScope();
  	} elseif ($expr instanceof Expr\Eval_) {

[staabm]

not sure why PHPStan reports

 ------ ----------------------------------------------------------------------------------------- 
  Line   src/Analyser/Generator/ExprHandler/UnaryMinusHandler.php                                 
 ------ ----------------------------------------------------------------------------------------- 
  44     Access to an undefined property PHPStan\Analyser\Generator\ExprAnalysisResult::$result.  
         🪪  property.notFound                                                                    
         💡  Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property    
         at src/Analyser/Generator/ExprHandler/UnaryMinusHandler.php:44                           
 ------ -----------------------------------------------------------------------------------------

here but it does not on line 40.

[ondrejmirtes]

I'm not sure what you mean. The reported lines are sometimes shifted because code is downgraded on lower PHP versions.

But $mulResult->result is really an error. It's supposed to be $mulResult->type?

[staabm]

ha, seems it was too early this morning ;).

hopefully we can make improvements so phpstorm autocomplete and type-discovery work better with this fiber code. atm it feels kind of unsupported.

are you aware whether there are already open issues on the phpstorm bugtracker to improve on type stuff with Fibers?

[ondrejmirtes]

In the handlers it's not about fibers but about generators. I think it's hard and no syntax was yet developed for this. We'd need something for @return Generator<... that would tell PHPStan + PhpStorm "when this is yielded, this is sent".

Psalm has @psalm-yield annotation but it doesn't make sense to me. Because what is sent depends on context. For the same yielded objects, different things can get sent to it in different generators.

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Thank you!