use call-site cache identifier

Author: staabm

src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php

@@ -129,7 +129,7 @@ public function create(string $projectInstallationPath): ?SourceLocator
 		}
 
 		if (count($files) > 0) {
-			$locators[] = $this->optimizedDirectorySourceLocatorFactory->createByFiles($files);
+			$locators[] = $this->optimizedDirectorySourceLocatorFactory->createByFiles($files, 'odsl-installed-files');
 		}
 
 		$binDir = ComposerHelper::getBinDirFromComposerConfig($projectInstallationPath, $composer);

src/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocatorFactory.php

@@ -10,13 +10,11 @@
 use PHPStan\Reflection\ConstantNameHelper;
 use function array_key_exists;
 use function count;
-use function implode;
 use function in_array;
 use function ltrim;
 use function php_strip_whitespace;
 use function preg_match_all;
 use function preg_replace;
-use function sha1;
 use function sha1_file;
 use function sprintf;
 use function strtolower;
@@ -104,8 +102,9 @@ private function createCachedDirectorySourceLocator(array $fileHashes, string $c
 
 	/**
 	 * @param string[] $files
+	 * @param non-empty-string&literal-string $uniqueCacheIdentifier
 	 */
-	public function createByFiles(array $files): OptimizedDirectorySourceLocator
+	public function createByFiles(array $files, string $uniqueCacheIdentifier): OptimizedDirectorySourceLocator
 	{
 		$fileHashes = [];
 		foreach ($files as $file) {
@@ -116,8 +115,7 @@ public function createByFiles(array $files): OptimizedDirectorySourceLocator
 			$fileHashes[$file] = $hash;
 		}
 
-		$cacheKey = sprintf('odsl-files-%s', sha1(implode(',', $files)));
-		return $this->createCachedDirectorySourceLocator($fileHashes, $cacheKey);
+		return $this->createCachedDirectorySourceLocator($fileHashes, $uniqueCacheIdentifier);
 	}
 
 	/**

tests/PHPStan/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocatorTest.php

@@ -307,7 +307,7 @@ public function testFunctionDoesNotExist(string $functionName): void
 	public function testBug5525(): void
 	{
 		$factory = self::getContainer()->getByType(OptimizedDirectorySourceLocatorFactory::class);
-		$locator = $factory->createByFiles([__DIR__ . '/data/bug-5525.php']);
+		$locator = $factory->createByFiles([__DIR__ . '/data/bug-5525.php'], 'bug5525-odsl-installed-files');
 		$reflector = new DefaultReflector($locator);
 
 		$class = $reflector->reflectClass('Faker\\Provider\\nl_BE\\Text');