Implement CastObjectHandler

Author: staabm

src/Analyser/Generator/ExprHandler/CastObjectHandler.php

@@ -0,0 +1,57 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser\Generator\ExprHandler;
+
+use Generator;
+use PhpParser\Node\Expr;
+use PhpParser\Node\Stmt;
+use PHPStan\Analyser\ExpressionContext;
+use PHPStan\Analyser\Generator\ExprAnalysisRequest;
+use PHPStan\Analyser\Generator\ExprAnalysisResult;
+use PHPStan\Analyser\Generator\ExprHandler;
+use PHPStan\Analyser\Generator\GeneratorScope;
+use PHPStan\Analyser\SpecifiedTypes;
+use PHPStan\DependencyInjection\AutowiredService;
+use PHPStan\Reflection\InitializerExprTypeResolver;
+
+/**
+ * @implements ExprHandler<Expr\Cast\Object_>
+ */
+#[AutowiredService]
+final class CastObjectHandler implements ExprHandler
+{
+
+	public function __construct(private InitializerExprTypeResolver $initializerExprTypeResolver)
+	{
+	}
+
+	public function supports(Expr $expr): bool
+	{
+		return $expr instanceof Expr\Cast\Object_;
+	}
+
+	public function analyseExpr(
+		Stmt $stmt,
+		Expr $expr,
+		GeneratorScope $scope,
+		ExpressionContext $context,
+		?callable $alternativeNodeCallback,
+	): Generator
+	{
+		$exprResult = yield new ExprAnalysisRequest($stmt, $expr->expr, $scope, $context->enterDeep(), $alternativeNodeCallback);
+
+		return new ExprAnalysisResult(
+			$this->initializerExprTypeResolver->getCastObjectType($exprResult->type),
+			$this->initializerExprTypeResolver->getCastObjectType($exprResult->nativeType),
+			$scope,
+			hasYield: false,
+			isAlwaysTerminating: false,
+			throwPoints: [],
+			impurePoints: [],
+			specifiedTruthyTypes: new SpecifiedTypes(),
+			specifiedFalseyTypes: new SpecifiedTypes(),
+			specifiedNullTypes: new SpecifiedTypes(),
+		);
+	}
+
+}

src/Reflection/InitializerExprTypeResolver.php

@@ -702,43 +702,47 @@ public function getCastType(Expr\Cast $expr, callable $getTypeCallback): Type
 			return $getTypeCallback($expr->expr)->toArray();
 		}
 		if ($expr instanceof Object_) {
-			$castToObject = static function (Type $type): Type {
-				$constantArrays = $type->getConstantArrays();
-				if (count($constantArrays) > 0) {
-					$objects = [];
-					foreach ($constantArrays as $constantArray) {
-						$properties = [];
-						$optionalProperties = [];
-						foreach ($constantArray->getKeyTypes() as $i => $keyType) {
-							$valueType = $constantArray->getValueTypes()[$i];
-							$optional = $constantArray->isOptionalKey($i);
-							if ($optional) {
-								$optionalProperties[] = $keyType->getValue();
-							}
-							$properties[$keyType->getValue()] = $valueType;
-						}
+			return $this->getCastObjectType($getTypeCallback($expr->expr));
+		}
 
-						$objects[] = TypeCombinator::intersect(new ObjectShapeType($properties, $optionalProperties), new ObjectType(stdClass::class));
+		return new MixedType();
+	}
+
+	public function getCastObjectType(Type $exprType): Type
+	{
+		$castToObject = static function (Type $type): Type {
+			$constantArrays = $type->getConstantArrays();
+			if (count($constantArrays) > 0) {
+				$objects = [];
+				foreach ($constantArrays as $constantArray) {
+					$properties = [];
+					$optionalProperties = [];
+					foreach ($constantArray->getKeyTypes() as $i => $keyType) {
+						$valueType = $constantArray->getValueTypes()[$i];
+						$optional = $constantArray->isOptionalKey($i);
+						if ($optional) {
+							$optionalProperties[] = $keyType->getValue();
+						}
+						$properties[$keyType->getValue()] = $valueType;
 					}
 
-					return TypeCombinator::union(...$objects);
-				}
-				if ($type->isObject()->yes()) {
-					return $type;
+					$objects[] = TypeCombinator::intersect(new ObjectShapeType($properties, $optionalProperties), new ObjectType(stdClass::class));
 				}
 
-				return new ObjectType('stdClass');
-			};
-
-			$exprType = $getTypeCallback($expr->expr);
-			if ($exprType instanceof UnionType) {
-				return TypeCombinator::union(...array_map($castToObject, $exprType->getTypes()));
+				return TypeCombinator::union(...$objects);
 			}
+			if ($type->isObject()->yes()) {
+				return $type;
+			}
+
+			return new ObjectType('stdClass');
+		};
 
-			return $castToObject($exprType);
+		if ($exprType instanceof UnionType) {
+			return TypeCombinator::union(...array_map($castToObject, $exprType->getTypes()));
 		}
 
-		return new MixedType();
+		return $castToObject($exprType);
 	}
 
 	/**

tests/PHPStan/Analyser/Generator/data/gnsr.php

@@ -241,7 +241,7 @@ function doCast() {
 
 		assertType('1', (int) $a);
 		assertType("array{'1'}", (array) $a);
-		// assertType("array{'1'}", (object) $a);
+		assertType('stdClass', (object) $a);
 		assertType('1.0', (double) $a);
 		assertType('true', (bool) $a);
 		assertType("'1'", (string) $a);