PromoteParameterRule - more precise line for LineRuleError

Author: ondrejmirtes

src/Rules/Playground/PromoteParameterRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\Rules\LineRuleError;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use function sprintf;
@@ -45,10 +46,13 @@ public function processNode(Node $node, Scope $scope): array
 
 		$errors = [];
 		foreach ($this->rule->processNode($node, $scope) as $error) {
-			$errors[] = RuleErrorBuilder::message($error->getMessage())
+			$builder = RuleErrorBuilder::message($error->getMessage())
 				->identifier('phpstanPlayground.configParameter')
-				->tip(sprintf('This error would be reported if the <fg=cyan>%s: true</> parameter was enabled in your <fg=cyan>%%configurationFile%%</>.', $this->parameterName))
-				->build();
+				->tip(sprintf('This error would be reported if the <fg=cyan>%s: true</> parameter was enabled in your <fg=cyan>%%configurationFile%%</>.', $this->parameterName));
+			if ($error instanceof LineRuleError) {
+				$builder->line($error->getLine());
+			}
+			$errors[] = $builder->build();
 		}
 
 		return $errors;

tests/PHPStan/Rules/Playground/PromoteParameterRuleTest.php

@@ -32,7 +32,7 @@ public function testRule(): void
 		$this->analyse([__DIR__ . '/data/promote-parameter.php'], [
 			[
 				'Class PromoteParameter\Foo has an uninitialized property $test. Give it default value or assign it in the constructor.',
-				5,
+				8,
 				'This error would be reported if the <fg=cyan>checkUninitializedProperties: true</> parameter was enabled in your <fg=cyan>%configurationFile%</>.',
 			],
 		]);