Fix calling createQueryBuilder() without alias argument

Author: ondrejmirtes

src/Type/Doctrine/QueryBuilder/EntityRepositoryCreateQueryBuilderDynamicReturnTypeExtension.php

@@ -8,6 +8,7 @@
 use PhpParser\Node\Scalar\String_;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
+use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
 use PHPStan\Type\Generic\GenericClassStringType;
 use PHPStan\Type\Type;
@@ -39,6 +40,10 @@ public function getTypeFromMethodCall(
 			$entityNameExpr = new String_($entityNameExprType->getGenericType()->getClassName());
 		}
 
+		if (!isset($methodCall->args[0])) {
+			return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+		}
+
 		$fromArgs = $methodCall->args;
 		array_unshift($fromArgs, new Arg($entityNameExpr));
 

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn-0.json

@@ -8,5 +8,15 @@
         "message": "Call to method Doctrine\\ORM\\EntityRepository<PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity>::findBy() - entity PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity does not have a field named $blah.",
         "line": 116,
         "ignorable": true
+    },
+    {
+        "message": "Method Doctrine\\ORM\\EntityRepository<mixed>::createQueryBuilder() invoked with 0 parameters, 1-2 required.",
+        "line": 239,
+        "ignorable": true
+    },
+    {
+        "message": "Could not analyse QueryBuilder with unknown beginning.",
+        "line": 241,
+        "ignorable": true
     }
 ]

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn-6.json

@@ -3,5 +3,10 @@
         "message": "Property PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\Example::$repository with generic class Doctrine\\ORM\\EntityRepository does not specify its types: TEntityClass",
         "line": 16,
         "ignorable": true
+    },
+    {
+        "message": "Class PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\Bug180Repository extends generic class Doctrine\\ORM\\EntityRepository but does not specify its types: TEntityClass",
+        "line": 232,
+        "ignorable": true
     }
 ]

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn.php

@@ -228,3 +228,16 @@ public function getRepository(): EntityRepository
 	abstract public function getEntityManager(): EntityManager;
 
 }
+
+class Bug180Repository extends EntityRepository
+{
+	public const ALIAS = 'o';
+
+
+	public function testingMethod(): int
+	{
+		$qb = $this->createQueryBuilder();
+
+		return (int) $qb->getQuery()->getSingleScalarResult();
+	}
+}