From fea2061161415691512933dacf9eb2d7f4df5b58 Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Wed, 28 Oct 2026 11:09:50 -0500 Subject: [PATCH] Expect attachments on the Print All Posts print page Co-Authored-By: Claude Opus 5.5 --- phpbb-test-board/feature_checks.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/phpbb-test-board/feature_checks.py b/phpbb-test-board/feature_checks.py index 42cab8c..6a59f2a 100755 --- a/phpbb-test-board/feature_checks.py +++ b/phpbb-test-board/feature_checks.py @@ -271,8 +271,7 @@ def sees_ip(s: requests.Session) -> bool: def check_printallposts(b: Board) -> None: - # A reply, so the topic has two posts, and an image attached to the welcome post, which the - # print page leaves out like phpBB's own print view + # A reply, so the topic has two posts, and an image attached to the welcome post forum = b.sql("SELECT forum_id FROM phpbb_posts WHERE post_id = 1")[0][0] now = int(time.time()) b.sql("INSERT INTO phpbb_posts (topic_id, forum_id, poster_id, poster_ip, post_time, post_visibility, " @@ -295,8 +294,7 @@ def check_printallposts(b: Board) -> None: body = admin.get(f"{b.base}/viewtopic.php?t=1&view=printall").text ok("Second probe post" in body and "This is an example post" in body, "with one post per page, the print page still shows both posts") - ok("printall-probe.gif" not in body and "attachbox" not in body, - "no attachments on the print page, as in phpBB's own print view") + ok("printall-probe.gif" in body, "the print page shows the post's attachment") finally: probe.unlink(missing_ok=True)