From a6e8b8e05308b8463cd2072c0317540abe3830cd Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Sun, 18 Oct 2026 21:13:43 -0500 Subject: [PATCH 1/2] Run EPV through the organization's strict EPV workflow EPV exits 0 on Error findings, so they never failed this workflow, and pointing it at the extension folder gave a false "Packaging structure" error. The old EPV steps are replaced by an epv job that calls phpbbmodders/.github's reusable EPV workflow on phpBB 3.3 and 4.0, which fails on any Fatal or Error finding not listed in .github/epv-allowed.txt. The one allowed finding is the unserialize() in ext.php, which reads phpBB's own migration data with allowed_classes off. Co-Authored-By: Claude Opus 5.5 --- .github/epv-allowed.txt | 8 ++++++++ .github/workflows/tests.yml | 29 ++++++++++------------------- 2 files changed, 18 insertions(+), 19 deletions(-) create mode 100644 .github/epv-allowed.txt diff --git a/.github/epv-allowed.txt b/.github/epv-allowed.txt new file mode 100644 index 0000000..f23fc84 --- /dev/null +++ b/.github/epv-allowed.txt @@ -0,0 +1,8 @@ +# EPV findings this extension keeps on purpose, checked by the epv job in +# .github/workflows/tests.yml. One finding per line as EPV prints it, without +# "on line N", with paths relative to the extension; give the reason above it. + +# ext.php reads phpBB's own serialized migration dependency lists when it moves +# an old rmcgirr83/contactadmin install, with allowed_classes off, so no objects +# can be created. +Error: Using unserialize in /ext.php diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 67db398..2680753 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -4,7 +4,6 @@ env: EXTNAME: phpbbmodders/contactadmin # Your extension vendor/package name SNIFF: 1 # Run code sniffer on your code? 1 or 0 IMAGE_ICC: 1 # Run icc profile sniffer on your images? 1 or 0 - EPV: 1 # Run EPV (Extension Pre Validator) on your code? 1 or 0 EXECUTABLE_FILES: 1 # Run check for executable files? 1 or 0 on: @@ -18,7 +17,7 @@ on: - develop jobs: - # START Basic Checks Job (EPV, code sniffer, images check, etc.) + # START Basic Checks Job (code sniffer, images check, etc.) basic-checks: runs-on: ubuntu-latest strategy: @@ -30,17 +29,11 @@ jobs: db: 'none' NOTESTS: 1 phpbb: '3.3.x' - composer: 'composer' - epv: 'dev-master' - # phpBB 4.0 (the master branch) with its minimum PHP. EPV's - # phpBB 4.0 branch, installed with phpBB's own Composer, as - # phpbb-extensions/test-framework does for phpBB 4.0 + # phpBB 4.0 (the master branch) with its minimum PHP - php: '8.2' db: 'none' NOTESTS: 1 phpbb: 'master' - composer: 'php ../composer.phar' - epv: 'dev-epv-phpbb4' name: PHP ${{ matrix.php }} - ${{ matrix.db }}${{ matrix.phpbb == 'master' && ' - phpBB 4.0' || '' }} @@ -75,11 +68,6 @@ jobs: run: .github/setup-phpbb.sh $DB $PHP_VERSION $NOTESTS working-directory: ./phpBB3 - - name: Setup EPV - if: ${{ env.EPV != 0 }} - run: ${{ matrix.composer }} require phpbb/epv:${{ matrix.epv }} --dev --no-interaction --ignore-platform-reqs - working-directory: ./phpBB3/phpBB - - name: Run code sniffer if: ${{ env.SNIFF != 0 }} env: @@ -96,9 +84,12 @@ jobs: if: ${{ env.EXECUTABLE_FILES != 0 }} run: .github/ext-check-executable-files.sh ./ $EXTNAME working-directory: ./phpBB3 - - - name: Run EPV - if: ${{ env.EPV != 0 }} - run: phpBB/vendor/bin/EPV.php run --dir="phpBB/ext/$EXTNAME/" - working-directory: ./phpBB3 # END Basic Checks Job + + # EPV (Extension Pre Validator), failing on any Fatal or Error finding not + # listed in .github/epv-allowed.txt + epv: + uses: phpbbmodders/.github/.github/workflows/epv.yml@3dcf8695befbfd207780c5a36d75799e6befb4a8 + with: + EXTNAME: phpbbmodders/contactadmin + PHPBB_BRANCHES: '["3.3.x", "master"]' From 206147db2c17d3d61f4ad6e8b19d5d92206616d8 Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Sun, 18 Oct 2026 21:24:14 -0500 Subject: [PATCH 2/2] Use the EPV workflow's v1 tag phpbbmodders/.github#2 is merged and tagged v1, so the pilot's pin to that PR's commit is replaced by the tag. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 2680753..a3ef58b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -89,7 +89,7 @@ jobs: # EPV (Extension Pre Validator), failing on any Fatal or Error finding not # listed in .github/epv-allowed.txt epv: - uses: phpbbmodders/.github/.github/workflows/epv.yml@3dcf8695befbfd207780c5a36d75799e6befb4a8 + uses: phpbbmodders/.github/.github/workflows/epv.yml@v1 with: EXTNAME: phpbbmodders/contactadmin PHPBB_BRANCHES: '["3.3.x", "master"]'