[BUGFIX] Mitigate "Using null as an array offset is deprecated" #422
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like some tests need updates unrelated to this pr. I will have a look at that. |
Contributor
Author
pushed again, should fix the phpstan stuff. I was to over-sensible and not checked things, lesser Not sure about the other tests - not that deep into this package. |
Using `DocBlockFactory->create()` with a phpdocblock hanging a `@throws` tag followed by a exception class name emits following PHP 8.5.0 deprecation: ``` Using null as an array offset is deprecated, use an empty string instead ``` in `StandardTagFactory->getArgumentsForParametersFromWiring()`. This change uses the null-coalsce operator to fallback to an empty string for the value which should be used as an array key instead of using `null` to mitigate the deprecation notice with PHP8.5.0 and matches the behaviour in earlier PHP versions without the deprecation message.
Member
|
Thanks, I will take over from here. |
Contributor
Author
Thanks ❤️ |
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 28, 2025
This change updates dependency "phpdocumentor/reflection-docblock"
to ensure having latest PHP8.5.0 related fixes on board. [1][2]
Used command(s):
> BIN_COMPOSER="$( which composer )" \
&& ${BIN_COMPOSER} require --no-update \
-d typo3/sysext/extbase \
'phpdocumentor/reflection-docblock':'^5.6.5' \
&& ${BIN_COMPOSER} require \
'phpdocumentor/reflection-docblock':'^5.6.5'
[1] phpDocumentor/ReflectionDocBlock#422
[2] https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.5
Resolves: #108359
Releases: main, 13.4, 12.4
Change-Id: Ie73e578949983c0039d33f882ff3b1ab3d2fdf8c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91910
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Garvin Hicking <garvin@hick.ing>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Garvin Hicking <garvin@hick.ing>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 28, 2025
This change updates dependency "phpdocumentor/reflection-docblock"
to ensure having latest PHP8.5.0 related fixes on board. [1][2]
Used command(s):
> BIN_COMPOSER="$( which composer )" \
&& ${BIN_COMPOSER} require --no-update \
-d typo3/sysext/extbase \
'phpdocumentor/reflection-docblock':'^5.6.5' \
&& ${BIN_COMPOSER} require \
'phpdocumentor/reflection-docblock':'^5.6.5'
[1] phpDocumentor/ReflectionDocBlock#422
[2] https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.5
Resolves: #108359
Releases: main, 13.4, 12.4
Change-Id: Ie73e578949983c0039d33f882ff3b1ab3d2fdf8c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91931
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/extbase
that referenced
this pull request
Nov 28, 2025
This change updates dependency "phpdocumentor/reflection-docblock"
to ensure having latest PHP8.5.0 related fixes on board. [1][2]
Used command(s):
> BIN_COMPOSER="$( which composer )" \
&& ${BIN_COMPOSER} require --no-update \
-d typo3/sysext/extbase \
'phpdocumentor/reflection-docblock':'^5.6.5' \
&& ${BIN_COMPOSER} require \
'phpdocumentor/reflection-docblock':'^5.6.5'
[1] phpDocumentor/ReflectionDocBlock#422
[2] https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.5
Resolves: #108359
Releases: main, 13.4, 12.4
Change-Id: Ie73e578949983c0039d33f882ff3b1ab3d2fdf8c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91910
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Garvin Hicking <garvin@hick.ing>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Garvin Hicking <garvin@hick.ing>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 28, 2025
This change updates dependency "phpdocumentor/reflection-docblock"
to ensure having latest PHP8.5.0 related fixes on board. [1][2]
Used command(s):
> BIN_COMPOSER="$( which composer )" \
&& ${BIN_COMPOSER} require --no-update \
-d typo3/sysext/extbase \
'phpdocumentor/reflection-docblock':'^5.6.5' \
&& ${BIN_COMPOSER} require \
'phpdocumentor/reflection-docblock':'^5.6.5'
[1] phpDocumentor/ReflectionDocBlock#422
[2] https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.5
Resolves: #108359
Releases: main, 13.4, 12.4
Change-Id: Ie73e578949983c0039d33f882ff3b1ab3d2fdf8c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91932
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/extbase
that referenced
this pull request
Nov 28, 2025
This change updates dependency "phpdocumentor/reflection-docblock"
to ensure having latest PHP8.5.0 related fixes on board. [1][2]
Used command(s):
> BIN_COMPOSER="$( which composer )" \
&& ${BIN_COMPOSER} require --no-update \
-d typo3/sysext/extbase \
'phpdocumentor/reflection-docblock':'^5.6.5' \
&& ${BIN_COMPOSER} require \
'phpdocumentor/reflection-docblock':'^5.6.5'
[1] phpDocumentor/ReflectionDocBlock#422
[2] https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.5
Resolves: #108359
Releases: main, 13.4, 12.4
Change-Id: Ie73e578949983c0039d33f882ff3b1ab3d2fdf8c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91931
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/extbase
that referenced
this pull request
Nov 28, 2025
This change updates dependency "phpdocumentor/reflection-docblock"
to ensure having latest PHP8.5.0 related fixes on board. [1][2]
Used command(s):
> BIN_COMPOSER="$( which composer )" \
&& ${BIN_COMPOSER} require --no-update \
-d typo3/sysext/extbase \
'phpdocumentor/reflection-docblock':'^5.6.5' \
&& ${BIN_COMPOSER} require \
'phpdocumentor/reflection-docblock':'^5.6.5'
[1] phpDocumentor/ReflectionDocBlock#422
[2] https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.5
Resolves: #108359
Releases: main, 13.4, 12.4
Change-Id: Ie73e578949983c0039d33f882ff3b1ab3d2fdf8c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91932
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
DocBlockFactory->create()with a phpdocblockhanging a
@throwstag followed by a exception classname emits following PHP 8.5.0 deprecation:
in
StandardTagFactory->getArgumentsForParametersFromWiring().This change uses the null-coalsce operator to fallback to
an empty string for the value which should be used as an
array key instead of using
nullto mitigate the deprecationnotice with PHP8.5.0 and matches the behaviour in earlier
PHP versions without the deprecation message.
This is blocking the TYPO3 pipelines to raise to PHP8.5.0
release images for automatic testing, which means that
after merging it a release is required aka would be very
nice to have it as soon as possible and the time fits in.