Merge pull request #36 from noplanman/fix_getupdates_secret

Secret should not be required for getUpdates when called via CLI.

Author: noplanman

CHANGELOG.md

@@ -9,6 +9,7 @@ Exclamation symbols (:exclamation:) note something of importance e.g. breaking c
 ### Deprecated
 ### Removed
 ### Fixed
+- Secret should not be required when using CLI for getUpdates.
 ### Security
 
 ## [1.2.0] - 2017-07-10

src/Params.php

@@ -152,8 +152,11 @@ private function validateAndSetBotParamsVital(array $params)
     private function validateAndSetBotParamsSpecial(array $params)
     {
         // Special case, where secret MUST be defined if we have a webhook.
-        if (($params['webhook'] ?? null) && !($params['secret'] ?? null)) {
-            throw new InvalidParamsException('Some vital info is missing: secret');
+        if (($params['webhook']['url'] ?? null) && !($params['secret'] ?? null)) {
+            // This does not apply when using CLI, but make sure it gets tested for!
+            if ('cli' !== PHP_SAPI || BotManager::inTest()) {
+                throw new InvalidParamsException('Some vital info is missing: secret');
+            }
         }
     }