Add invalid action to error message.

Add random test to verify valid action.

Author: noplanman

src/Action.php

@@ -39,7 +39,7 @@ public function __construct($action = 'handle')
         $this->action = $action ?: 'handle';
 
         if (!$this->isAction(self::$valid_actions)) {
-            throw new \InvalidArgumentException('Invalid action');
+            throw new \InvalidArgumentException('Invalid action: ' . $this->action);
         }
     }
 
@@ -64,4 +64,14 @@ public function getAction(): string
     {
         return $this->action;
     }
+
+    /**
+     * Return a list of valid actions.
+     *
+     * @return array
+     */
+    public static function getValidActions(): array
+    {
+        return self::$valid_actions;
+    }
 }

tests/TelegramBotManager/Tests/ActionTest.php

@@ -14,16 +14,20 @@
 
 class ActionTest extends \PHPUnit_Framework_TestCase
 {
-    /**
-     * @expectedException \InvalidArgumentException
-     * @expectedExceptionMessage Invalid action
-     */
     public function testConstruct()
     {
         self::assertEquals('set', (new Action('set'))->getAction());
         self::assertEquals('unset', (new Action('unset'))->getAction());
         self::assertEquals('reset', (new Action('reset'))->getAction());
         self::assertEquals('handle', (new Action('handle'))->getAction());
+    }
+
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessageRegExp /^Invalid action: non-existent$/
+     */
+    public function testConstructFail()
+    {
         new Action('non-existent');
     }
 
@@ -35,6 +39,12 @@ public function testIsAction()
         self::assertFalse($action->isAction('unset'));
         self::assertFalse($action->isAction(['unset', 'reset']));
 
+        // Random action.
+        $valid_actions = Action::getValidActions();
+        $random_action = $valid_actions[array_rand($valid_actions)];
+        $action        = new Action($random_action);
+        self::assertTrue($action->isAction(Action::getValidActions()));
+
         // Test some weird values.
         self::assertFalse($action->isAction(null));
         self::assertFalse($action->isAction(true));