Merge pull request #34 from noplanman/26-single_fail_log

Only make a single log entry for a failed welcome message deletion.

Author: noplanman

CHANGELOG.md

@@ -6,6 +6,7 @@ Exclamation symbols (:exclamation:) note something of importance e.g. breaking c
 ## [Unreleased]
 ### Added
 ### Changed
+- Only log a single welcome message deletion failure.
 ### Deprecated
 ### Removed
 ### Fixed

src/Helpers.php

@@ -72,18 +72,18 @@ public static function deleteOldWelcomeMessages(): void
             }
 
             $deletion = Request::deleteMessage(compact('chat_id', 'message_id'));
-            if ($deletion->isOk()) {
-                unset($welcome_message_ids[$key]);
-                continue;
+            if (!$deletion->isOk()) {
+                // Let's just save the error for now if it fails, to see if we can fix this better.
+                TelegramLog::error(sprintf(
+                    'Chat ID: %s, Message ID: %s, Error Code: %s, Error Message: %s',
+                    $chat_id,
+                    $message_id,
+                    $deletion->getErrorCode(),
+                    $deletion->getDescription()
+                ));
             }
 
-            // Let's just save the error for now if it fails, to see if we can fix this better.
-            TelegramLog::error(sprintf(
-                'Message ID: %s, Error Code: %s, Error Message: %s',
-                $message_id,
-                $deletion->getErrorCode(),
-                $deletion->getDescription()
-            ));
+            unset($welcome_message_ids[$key]);
         }
 
         self::setSimpleOption('welcome_message_ids', $welcome_message_ids);