Merge pull request #144 from php-school/scrutinizer-fixes

Scrutinizer fixes

Author: AydinHassan

src/ResultRenderer/CgiResultRenderer.php

@@ -16,7 +16,7 @@ class CgiResultRenderer implements ResultRendererInterface
 {
 
     /**
-     * @var CgiOutResult
+     * @var CgiResult
      */
     private $result;
 

test/Result/Cgi/CgiResultTest.php

@@ -27,7 +27,7 @@ public function testIsSuccessful()
 
         $this->assertFalse($cgiResult->isSuccessful());
 
-        $cgiResult = new CgiResult([new Success($this->createMock(RequestInterface::class), 'Successful Check')]);
+        $cgiResult = new CgiResult([new Success($this->createMock(RequestInterface::class))]);
         $this->assertTrue($cgiResult->isSuccessful());
 
         $cgiResult->add($request);

test/ResultRenderer/CliResultRendererTest.php

@@ -8,7 +8,6 @@
 use PhpSchool\PhpWorkshop\ResultRenderer\Cli\RequestFailureRenderer;
 use PhpSchool\PhpWorkshop\ResultRenderer\CliResultRenderer;
 use PhpSchool\PhpWorkshop\Utils\ArrayObject;
-use PhpSchool\PhpWorkshop\Utils\RequestRenderer;
 
 /**
  * @author Aydin Hassan <aydin@hotmail.co.uk>
@@ -18,7 +17,7 @@ class CliResultRendererTest extends AbstractResultRendererTest
     public function testNothingIsOutputIfNoFailures()
     {
         $result = new CliResult([new Success(new ArrayObject)]);
-        $renderer = new CliResultRenderer($result, new RequestRenderer);
+        $renderer = new CliResultRenderer($result);
 
         $this->assertEmpty($renderer->render($this->getRenderer()));
     }
@@ -42,7 +41,7 @@ function (RequestFailure $failure) use ($failureRenderer) {
             'ACTUAL OUTPUT'
         );
         $result = new CliResult([$failure]);
-        $renderer = new CliResultRenderer($result, new RequestRenderer);
+        $renderer = new CliResultRenderer($result);
 
         $expected  = "Some executions of your solution produced incorrect output!\n";
         $expected .= "\e[33m──────────────────────────────────────────────────\e[0m\n";
@@ -72,7 +71,7 @@ function (RequestFailure $failure) use ($failureRenderer) {
             'ACTUAL OUTPUT'
         );
         $result = new CliResult([$failure]);
-        $renderer = new CliResultRenderer($result, new RequestRenderer);
+        $renderer = new CliResultRenderer($result);
 
         $expected  = "Some executions of your solution produced incorrect output!\n";
         $expected .= "\e[33m──────────────────────────────────────────────────\e[0m\n";