add return type declarations #6

Author: gregor-j

src/SapDateInterval.php

@@ -38,7 +38,7 @@ class SapDateInterval extends DateInterval
      * @throws Exception
      * @link https://php.net/manual/en/dateinterval.createfromdatestring.php
      */
-    public static function createFromDateString($datetime)
+    public static function createFromDateString($datetime): DateInterval
     {
         $matches = [];
         if (preg_match('~^([\d]{2})([0-5][\d])([0-5][\d])$~', $datetime, $matches)) {

tests/SapDateIntervalTest.php

@@ -32,7 +32,7 @@ class SapDateIntervalTest extends TestCase
      * Data provider for valid time return values from SAP.
      * @return array
      */
-    public static function provideValidTimes()
+    public static function provideValidTimes(): array
     {
         return [
             ['010203', '2020-01-31 00:00:00', '2020-01-31 01:02:03'],

tests/SapDateTimeTest.php

@@ -34,7 +34,7 @@ class SapDateTimeTest extends TestCase
      *
      * @return array
      */
-    public static function validSapWeeks()
+    public static function validSapWeeks(): array
     {
         return [
             ['201846', '2018 week 46', '2018-11-12 00:00:00'],
@@ -69,7 +69,7 @@ public function testParseSapWeeks(string $sapWeek, string $expected, string $tim
      *
      * @return array
      */
-    public static function invalidSapWeeks()
+    public static function invalidSapWeeks(): array
     {
         return [
             ['189952'],
@@ -96,7 +96,7 @@ public function testParseInvalidSapWeeks(string $sapWeek)
      * Data provider of timestamps and their according SAP week strings.
      * @return array
      */
-    public static function timestampsAndSapWeeks()
+    public static function timestampsAndSapWeeks(): array
     {
         return [
             ['2018-10-19 08:09:10', '201842'],
@@ -127,7 +127,7 @@ public function testCreateSapWeeks(string $timestamp, string $expected)
      * Data provider of SAP dates and their ISO date representations.
      * @return array
      */
-    public static function sapDatesAndIsoDates()
+    public static function sapDatesAndIsoDates(): array
     {
         return [
             ['20181101', '2018-11-01 00:00:00'],
@@ -157,7 +157,7 @@ public function testParseSapDates(string $sapDate, string $isoDate)
      * Data provider of times and their according SAP time strings.
      * @return array
      */
-    public static function timesAndSapTimes()
+    public static function timesAndSapTimes(): array
     {
         return [
             ['08:10:31', '081031'],
@@ -197,7 +197,7 @@ public function testParseSapTimes(string $isoTime, string $sapTime)
      * Data provider of timestamps and their according SAP dates.
      * @return array
      */
-    public static function timestampsAndSapDates()
+    public static function timestampsAndSapDates(): array
     {
         return [
             ['2018-12-21 08:09:10', '20181221'],
@@ -227,7 +227,7 @@ public function testCreateSapDates(string $timestamp, string $sapDate)
      * Data provider of timestamps and their according SAP timestamps.
      * @return array
      */
-    public static function timestampsAndSapTimestamps()
+    public static function timestampsAndSapTimestamps(): array
     {
         return [
             ['2018-10-19 08:09:10', '20181019080910'],
@@ -270,7 +270,7 @@ public function testCreateSapTimestamps(string $isotime, string $saptime)
      * Data provider for timezones.
      * @return array
      */
-    public static function provideTimezones()
+    public static function provideTimezones(): array
     {
         return [
             [