Return clean response with robots.txt and fixed content

Author: snapshotpl

phpunit.xml

@@ -2,7 +2,7 @@
 
 <phpunit bootstrap="./vendor/autoload.php" colors="true">
     <testsuites>
-        <testsuite name="PhpMiddleware\\BlockRobots Tests">
+        <testsuite>
             <directory>./test</directory>
         </testsuite>
     </testsuites>

src/BlockRobotsMiddleware.php

@@ -4,6 +4,7 @@
 
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
+use Zend\Diactoros\Response;
 
 class BlockRobotsMiddleware
 {
@@ -12,8 +13,10 @@ class BlockRobotsMiddleware
     public function __invoke(ServerRequestInterface $request, ResponseInterface $response, callable $out = null)
     {
         if ($request->getUri()->getPath() === '/robots.txt') {
-            $response->getBody()->write('Disallow: /');
-            return $response->withHeader('Content-Type', 'text/plain');
+            $newReponse = new Response('php://memory', 200, ['Content-Type' => 'text/plain']);
+            $newReponse->getBody()->write("User-Agent: *\nDisallow: /");
+
+            return $newReponse;
         }
         /* @var $out ResponseInterface */
         $response = $out === null ? $response : $out($request, $response);

test/BlockRobotsMiddlewareTest.php

@@ -6,6 +6,7 @@
 use Psr\Http\Message\ResponseInterface;
 use Zend\Diactoros\Response;
 use Zend\Diactoros\ServerRequest;
+use Zend\Diactoros\Uri;
 
 class BlockRobotsMiddlewareTest extends \PHPUnit_Framework_TestCase
 {
@@ -33,14 +34,14 @@ public function testNoIndexHeader()
 
         $this->assertTrue($calledOut, 'Out was not called');
         $this->assertNotSame($response, $result);
+        $this->assertInstanceOf(ResponseInterface::class, $result);
         $this->assertEquals('noindex, nofollow', $result->getHeaderLine(BlockRobotsMiddleware::ROBOTS_HEADER));
     }
 
     public function testRobots()
     {
-        $uri = new \Zend\Diactoros\Uri('http://foo/robots.txt');
-        $request = new ServerRequest();
-        $request = $request->withUri($uri);
+        $uri = new Uri('http://foo/robots.txt');
+        $request = new ServerRequest([], [], $uri);
         $response = new Response();
         $calledOut = false;
 
@@ -55,8 +56,9 @@ public function testRobots()
 
         $this->assertFalse($calledOut, 'Out was called');
         $this->assertNotSame($response, $result);
+        $this->assertInstanceOf(ResponseInterface::class, $result);
         $this->assertFalse($result->hasHeader(BlockRobotsMiddleware::ROBOTS_HEADER));
-        $this->assertEquals('Disallow: /', (string) $result->getBody());
-        $this->assertEquals('text/plain', $result->getHeaderLine('Content-Type'));
+        $this->assertSame("User-Agent: *\nDisallow: /", (string) $result->getBody());
+        $this->assertSame('text/plain', $result->getHeaderLine('Content-Type'));
     }
 }