Skip to content

Commit 37b293b

Browse files
authored
Merge pull request #7 from php-etl/feature/logger
Added logger management + updated tests
2 parents aa5a4f6 + 73c4e8e commit 37b293b

File tree

10 files changed

+21
-18
lines changed

10 files changed

+21
-18
lines changed

.github/workflows/infection.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
- uses: actions/checkout@v2
88
- uses: shivammathur/setup-php@v2
99
with:
10-
php-version: '8.0'
10+
php-version: '8.1'
1111
tools: composer:v2
1212
coverage: pcov
1313
- uses: actions/cache@v2
@@ -19,7 +19,7 @@ jobs:
1919
- uses: php-actions/composer@v5
2020
with:
2121
args: --prefer-dist
22-
php_version: 8.0
22+
php_version: 8.1
2323

2424
- name: Infection
2525
run: |

.github/workflows/phpstan-5.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- uses: php-actions/composer@v5
1515
with:
1616
args: --prefer-dist
17-
php_version: 8.0
17+
php_version: 8.1
1818

1919
- name: PHPStan
2020
uses: php-actions/phpstan@v2

.github/workflows/phpstan-7.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- uses: php-actions/composer@v5
1515
with:
1616
args: --prefer-dist
17-
php_version: 8.0
17+
php_version: 8.1
1818

1919
- name: PHPStan
2020
uses: php-actions/phpstan@v2

.github/workflows/phpstan-8.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- uses: php-actions/composer@v5
1515
with:
1616
args: --prefer-dist
17-
php_version: 8.0
17+
php_version: 8.1
1818

1919
- name: PHPStan
2020
uses: php-actions/phpstan@v2

.github/workflows/quality.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- uses: actions/checkout@v2
1818
- uses: shivammathur/setup-php@v2
1919
with:
20-
php-version: '8.0'
20+
php-version: '8.1'
2121
tools: composer:v2
2222
coverage: pcov
2323
- uses: actions/cache@v2
@@ -29,7 +29,7 @@ jobs:
2929
- uses: php-actions/composer@v5
3030
with:
3131
args: --prefer-dist
32-
php_version: 8.0
32+
php_version: 8.1
3333

3434
- name: Run tests & generate Coverage
3535
run: bin/phpunit --configuration=phpunit.xml tests --coverage-html var/coverage --whitelist=src
@@ -52,7 +52,7 @@ jobs:
5252
- uses: php-actions/composer@v5
5353
with:
5454
args: --prefer-dist
55-
php_version: 8.0
55+
php_version: 8.1
5656

5757
- name: PHPStan
5858
uses: php-actions/phpstan@v2

composer.lock

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Builder/Extractor.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ class: new Node\Name\FullyQualified('Kiboko\\Component\\Flow\\SQL\\Extractor'),
127127
: new Node\Expr\Array_(attributes: [
128128
'kind' => Node\Expr\Array_::KIND_SHORT
129129
]),
130+
new Node\Arg(value: $this->logger ?? new Node\Expr\New_(new Node\Name\FullyQualified('Psr\\Log\\NullLogger'))),
130131
],
131132
);
132133
}

src/Builder/Loader.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ class: new Node\Name\FullyQualified('Kiboko\\Component\\Flow\\SQL\\Loader'),
130130
: new Node\Expr\Array_(attributes: [
131131
'kind' => Node\Expr\Array_::KIND_SHORT
132132
]),
133+
new Node\Arg(value: $this->logger ?? new Node\Expr\New_(new Node\Name\FullyQualified('Psr\\Log\\NullLogger'))),
133134
],
134135
);
135136
}

src/Builder/Lookup.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ class: new Node\Name\FullyQualified('Psr\Log\NullLogger')
190190
new Node\Arg(
191191
value: $this->compileAfterQueries()
192192
),
193+
new Node\Arg(value: $this->logger ?? new Node\Expr\New_(new Node\Name\FullyQualified('Psr\\Log\\NullLogger'))),
193194
],
194195
);
195196
}

tests/functional/ServiceTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -457,11 +457,11 @@ public function testExtractor(): void
457457
$this->assertBuildsExtractorExtractsExactly(
458458
[
459459
[
460-
'id' => '1',
460+
'id' => 1,
461461
'value' => 'Lorem ipsum dolor',
462462
],
463463
[
464-
'id' => '2',
464+
'id' => 2,
465465
'value' => 'Sit amet consecutir',
466466
],
467467
],

0 commit comments

Comments
 (0)