Fixed "Property is never read, only written." and "Cannot access uninitialized non-nullable property"

sebprt · sebprt · commit 325a71306ad9 · 2022-05-16T10:17:15.000+02:00
diff --git a/src/Builder/AlternativeLoader.php b/src/Builder/AlternativeLoader.php
@@ -7,39 +7,27 @@
 
 final class AlternativeLoader implements StepBuilderInterface
 {
-    private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
     /** @var array<array-key, array{value: Node\Expr, type: string}> */
     private array $parameters;
 
     public function __construct(
         private Node\Expr $query
     ) {
-        $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
         $this->parameters = [];
     }
 
     public function withLogger(Node\Expr $logger): StepBuilderInterface
     {
-        $this->logger = $logger;
-
         return $this;
     }
 
     public function withRejection(Node\Expr $rejection): StepBuilderInterface
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): StepBuilderInterface
     {
-        $this->state = $state;
-
         return $this;
     }
 
diff --git a/src/Builder/AlternativeLookup.php b/src/Builder/AlternativeLookup.php
@@ -9,40 +9,28 @@
 
 final class AlternativeLookup implements StepBuilderInterface
 {
-    private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
     /** @var array<array-key, array{value: Node\Expr, type: string}> */
     private array $parameters;
     private ?Builder $merge;
 
     public function __construct(private Node\Expr $query)
     {
-        $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
         $this->parameters = [];
         $this->merge = null;
     }
 
     public function withLogger(Node\Expr $logger): StepBuilderInterface
     {
-        $this->logger = $logger;
-
         return $this;
     }
 
     public function withRejection(Node\Expr $rejection): StepBuilderInterface
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): StepBuilderInterface
     {
-        $this->state = $state;
-
         return $this;
     }
 
@@ -362,7 +350,7 @@ class: new Node\Name('DateTimeImmutable'),
         }
     }
 
-    private function compileParameterType(array $parameter): ?Node\Arg
+    private function compileParameterType(array $parameter): Node\Arg
     {
         return match ($parameter["type"]) {
             'integer' => new Node\Arg(
diff --git a/src/Builder/ConditionalLoader.php b/src/Builder/ConditionalLoader.php
@@ -10,8 +10,6 @@
 final class ConditionalLoader implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
     /** @var array<array{Node\Expr, AlternativeLoader}> */
     private iterable $alternatives;
     /** @var array<int, InitializerQueries> */
@@ -23,8 +21,6 @@ public function __construct(
         private null|Node\Expr|Connection $connection = null,
     ) {
         $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
         $this->alternatives = [];
         $this->beforeQueries = [];
         $this->afterQueries = [];
@@ -39,15 +35,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface
 
     public function withRejection(Node\Expr $rejection): StepBuilderInterface
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): StepBuilderInterface
     {
-        $this->state = $state;
-
         return $this;
     }
 
diff --git a/src/Builder/ConditionalLookup.php b/src/Builder/ConditionalLookup.php
@@ -10,8 +10,6 @@
 final class ConditionalLookup implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
     /** @var array<array{Node\Expr, AlternativeLoader}> */
     private iterable $alternatives;
     /** @var array<int, InitializerQueries> */
@@ -23,8 +21,6 @@ public function __construct(
         private null|Node\Expr|Connection $connection = null
     ) {
         $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
         $this->alternatives = [];
         $this->beforeQueries = [];
         $this->afterQueries = [];
@@ -39,15 +35,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface
 
     public function withRejection(Node\Expr $rejection): StepBuilderInterface
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): StepBuilderInterface
     {
-        $this->state = $state;
-
         return $this;
     }
 
diff --git a/src/Builder/Extractor.php b/src/Builder/Extractor.php
@@ -8,8 +8,6 @@
 final class Extractor implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
     /** @var array<int, InitializerQueries> */
     private array $beforeQueries;
     /** @var array<int, InitializerQueries> */
@@ -21,8 +19,6 @@ public function __construct(
         private null|Node\Expr|Connection $connection = null,
     ) {
         $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
         $this->beforeQueries = [];
         $this->afterQueries = [];
         $this->parameters = [];
@@ -37,15 +33,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface
 
     public function withRejection(Node\Expr $rejection): StepBuilderInterface
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): StepBuilderInterface
     {
-        $this->state = $state;
-
         return $this;
     }
 
diff --git a/src/Builder/Loader.php b/src/Builder/Loader.php
@@ -8,8 +8,6 @@
 final class Loader implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
     /** @var array<int, InitializerQueries> */
     private array $beforeQueries;
     /** @var array<int, InitializerQueries> */
@@ -21,8 +19,6 @@ public function __construct(
         private null|Node\Expr|Connection $connection = null,
     ) {
         $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
         $this->beforeQueries = [];
         $this->afterQueries = [];
         $this->parameters = [];
@@ -37,15 +33,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface
 
     public function withRejection(Node\Expr $rejection): StepBuilderInterface
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): StepBuilderInterface
     {
-        $this->state = $state;
-
         return $this;
     }
 
diff --git a/src/Builder/Lookup.php b/src/Builder/Lookup.php
@@ -8,8 +8,6 @@
 final class Lookup implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
     /** @var array<int, InitializerQueries> */
     private array $beforeQueries;
     /** @var array<int, InitializerQueries> */
@@ -20,8 +18,6 @@ public function __construct(
         private null|Node\Expr|Connection $connection = null,
     ) {
         $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
         $this->beforeQueries = [];
         $this->afterQueries = [];
     }
@@ -35,15 +31,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface
 
     public function withRejection(Node\Expr $rejection): StepBuilderInterface
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): StepBuilderInterface
     {
-        $this->state = $state;
-
         return $this;
     }
 
diff --git a/src/Factory/Repository/Extractor.php b/src/Factory/Repository/Extractor.php
@@ -14,6 +14,8 @@ class Extractor implements StepRepositoryInterface
 
     public function __construct(private SQL\Builder\Extractor $builder)
     {
+        $this->files = [];
+        $this->packages = [];
     }
 
     public function withConnection(Connection $connection): self
diff --git a/src/Factory/Repository/Loader.php b/src/Factory/Repository/Loader.php
@@ -14,6 +14,8 @@ class Loader implements StepRepositoryInterface
 
     public function __construct(private SQL\Builder\Loader|SQL\Builder\ConditionalLoader $builder)
     {
+        $this->files = [];
+        $this->packages = [];
     }
 
     public function withConnection(Connection $connection): self
diff --git a/src/Factory/Repository/Lookup.php b/src/Factory/Repository/Lookup.php
@@ -14,6 +14,8 @@ class Lookup implements StepRepositoryInterface
 
     public function __construct(private SQL\Builder\Lookup|SQL\Builder\ConditionalLookup $builder)
     {
+        $this->files = [];
+        $this->packages = [];
     }
 
     public function withConnection(Connection $connection): self

Original file line number	Diff line number	Diff line change
`@@ -7,39 +7,27 @@`
`7`	`7`
`8`	`8`	`final class AlternativeLoader implements StepBuilderInterface`
`9`	`9`	`{`
`10`		`- private ?Node\Expr $logger;`
`11`		`- private ?Node\Expr $rejection;`
`12`		`- private ?Node\Expr $state;`
`13`	`10`	`/** @var array<array-key, array{value: Node\Expr, type: string}> */`
`14`	`11`	`private array $parameters;`
`15`	`12`
`16`	`13`	`public function __construct(`
`17`	`14`	`private Node\Expr $query`
`18`	`15`	`) {`
`19`		`- $this->logger = null;`
`20`		`- $this->rejection = null;`
`21`		`- $this->state = null;`
`22`	`16`	`$this->parameters = [];`
`23`	`17`	`}`
`24`	`18`
`25`	`19`	`public function withLogger(Node\Expr $logger): StepBuilderInterface`
`26`	`20`	`{`
`27`		`- $this->logger = $logger;`
`28`		`-`
`29`	`21`	`return $this;`
`30`	`22`	`}`
`31`	`23`
`32`	`24`	`public function withRejection(Node\Expr $rejection): StepBuilderInterface`
`33`	`25`	`{`
`34`		`- $this->rejection = $rejection;`
`35`		`-`
`36`	`26`	`return $this;`
`37`	`27`	`}`
`38`	`28`
`39`	`29`	`public function withState(Node\Expr $state): StepBuilderInterface`
`40`	`30`	`{`
`41`		`- $this->state = $state;`
`42`		`-`
`43`	`31`	`return $this;`
`44`	`32`	`}`
`45`	`33`
Original file line number	Diff line number	Diff line change
`@@ -9,40 +9,28 @@`
`9`	`9`
`10`	`10`	`final class AlternativeLookup implements StepBuilderInterface`
`11`	`11`	`{`
`12`		`- private ?Node\Expr $logger;`
`13`		`- private ?Node\Expr $rejection;`
`14`		`- private ?Node\Expr $state;`
`15`	`12`	`/** @var array<array-key, array{value: Node\Expr, type: string}> */`
`16`	`13`	`private array $parameters;`
`17`	`14`	`private ?Builder $merge;`
`18`	`15`
`19`	`16`	`public function __construct(private Node\Expr $query)`
`20`	`17`	`{`
`21`		`- $this->logger = null;`
`22`		`- $this->rejection = null;`
`23`		`- $this->state = null;`
`24`	`18`	`$this->parameters = [];`
`25`	`19`	`$this->merge = null;`
`26`	`20`	`}`
`27`	`21`
`28`	`22`	`public function withLogger(Node\Expr $logger): StepBuilderInterface`
`29`	`23`	`{`
`30`		`- $this->logger = $logger;`
`31`		`-`
`32`	`24`	`return $this;`
`33`	`25`	`}`
`34`	`26`
`35`	`27`	`public function withRejection(Node\Expr $rejection): StepBuilderInterface`
`36`	`28`	`{`
`37`		`- $this->rejection = $rejection;`
`38`		`-`
`39`	`29`	`return $this;`
`40`	`30`	`}`
`41`	`31`
`42`	`32`	`public function withState(Node\Expr $state): StepBuilderInterface`
`43`	`33`	`{`
`44`		`- $this->state = $state;`
`45`		`-`
`46`	`34`	`return $this;`
`47`	`35`	`}`
`48`	`36`
`@@ -362,7 +350,7 @@ class: new Node\Name('DateTimeImmutable'),`
`362`	`350`	`}`
`363`	`351`	`}`
`364`	`352`
`365`		`- private function compileParameterType(array $parameter): ?Node\Arg`
	`353`	`+ private function compileParameterType(array $parameter): Node\Arg`
`366`	`354`	`{`
`367`	`355`	`return match ($parameter["type"]) {`
`368`	`356`	`'integer' => new Node\Arg(`
Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,6 @@`
`10`	`10`	`final class ConditionalLoader implements StepBuilderInterface`
`11`	`11`	`{`
`12`	`12`	`private ?Node\Expr $logger;`
`13`		`- private ?Node\Expr $rejection;`
`14`		`- private ?Node\Expr $state;`
`15`	`13`	`/** @var array<array{Node\Expr, AlternativeLoader}> */`
`16`	`14`	`private iterable $alternatives;`
`17`	`15`	`/** @var array<int, InitializerQueries> */`
`@@ -23,8 +21,6 @@ public function __construct(`
`23`	`21`	`private null\|Node\Expr\|Connection $connection = null,`
`24`	`22`	`) {`
`25`	`23`	`$this->logger = null;`
`26`		`- $this->rejection = null;`
`27`		`- $this->state = null;`
`28`	`24`	`$this->alternatives = [];`
`29`	`25`	`$this->beforeQueries = [];`
`30`	`26`	`$this->afterQueries = [];`
`@@ -39,15 +35,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface`
`39`	`35`
`40`	`36`	`public function withRejection(Node\Expr $rejection): StepBuilderInterface`
`41`	`37`	`{`
`42`		`- $this->rejection = $rejection;`
`43`		`-`
`44`	`38`	`return $this;`
`45`	`39`	`}`
`46`	`40`
`47`	`41`	`public function withState(Node\Expr $state): StepBuilderInterface`
`48`	`42`	`{`
`49`		`- $this->state = $state;`
`50`		`-`
`51`	`43`	`return $this;`
`52`	`44`	`}`
`53`	`45`
Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,6 @@`
`8`	`8`	`final class Extractor implements StepBuilderInterface`
`9`	`9`	`{`
`10`	`10`	`private ?Node\Expr $logger;`
`11`		`- private ?Node\Expr $rejection;`
`12`		`- private ?Node\Expr $state;`
`13`	`11`	`/** @var array<int, InitializerQueries> */`
`14`	`12`	`private array $beforeQueries;`
`15`	`13`	`/** @var array<int, InitializerQueries> */`
`@@ -21,8 +19,6 @@ public function __construct(`
`21`	`19`	`private null\|Node\Expr\|Connection $connection = null,`
`22`	`20`	`) {`
`23`	`21`	`$this->logger = null;`
`24`		`- $this->rejection = null;`
`25`		`- $this->state = null;`
`26`	`22`	`$this->beforeQueries = [];`
`27`	`23`	`$this->afterQueries = [];`
`28`	`24`	`$this->parameters = [];`
`@@ -37,15 +33,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface`
`37`	`33`
`38`	`34`	`public function withRejection(Node\Expr $rejection): StepBuilderInterface`
`39`	`35`	`{`
`40`		`- $this->rejection = $rejection;`
`41`		`-`
`42`	`36`	`return $this;`
`43`	`37`	`}`
`44`	`38`
`45`	`39`	`public function withState(Node\Expr $state): StepBuilderInterface`
`46`	`40`	`{`
`47`		`- $this->state = $state;`
`48`		`-`
`49`	`41`	`return $this;`
`50`	`42`	`}`
`51`	`43`
Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,6 @@`
`8`	`8`	`final class Loader implements StepBuilderInterface`
`9`	`9`	`{`
`10`	`10`	`private ?Node\Expr $logger;`
`11`		`- private ?Node\Expr $rejection;`
`12`		`- private ?Node\Expr $state;`
`13`	`11`	`/** @var array<int, InitializerQueries> */`
`14`	`12`	`private array $beforeQueries;`
`15`	`13`	`/** @var array<int, InitializerQueries> */`
`@@ -21,8 +19,6 @@ public function __construct(`
`21`	`19`	`private null\|Node\Expr\|Connection $connection = null,`
`22`	`20`	`) {`
`23`	`21`	`$this->logger = null;`
`24`		`- $this->rejection = null;`
`25`		`- $this->state = null;`
`26`	`22`	`$this->beforeQueries = [];`
`27`	`23`	`$this->afterQueries = [];`
`28`	`24`	`$this->parameters = [];`
`@@ -37,15 +33,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface`
`37`	`33`
`38`	`34`	`public function withRejection(Node\Expr $rejection): StepBuilderInterface`
`39`	`35`	`{`
`40`		`- $this->rejection = $rejection;`
`41`		`-`
`42`	`36`	`return $this;`
`43`	`37`	`}`
`44`	`38`
`45`	`39`	`public function withState(Node\Expr $state): StepBuilderInterface`
`46`	`40`	`{`
`47`		`- $this->state = $state;`
`48`		`-`
`49`	`41`	`return $this;`
`50`	`42`	`}`
`51`	`43`
Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,6 @@`
`8`	`8`	`final class Lookup implements StepBuilderInterface`
`9`	`9`	`{`
`10`	`10`	`private ?Node\Expr $logger;`
`11`		`- private ?Node\Expr $rejection;`
`12`		`- private ?Node\Expr $state;`
`13`	`11`	`/** @var array<int, InitializerQueries> */`
`14`	`12`	`private array $beforeQueries;`
`15`	`13`	`/** @var array<int, InitializerQueries> */`
`@@ -20,8 +18,6 @@ public function __construct(`
`20`	`18`	`private null\|Node\Expr\|Connection $connection = null,`
`21`	`19`	`) {`
`22`	`20`	`$this->logger = null;`
`23`		`- $this->rejection = null;`
`24`		`- $this->state = null;`
`25`	`21`	`$this->beforeQueries = [];`
`26`	`22`	`$this->afterQueries = [];`
`27`	`23`	`}`
`@@ -35,15 +31,11 @@ public function withLogger(Node\Expr $logger): StepBuilderInterface`
`35`	`31`
`36`	`32`	`public function withRejection(Node\Expr $rejection): StepBuilderInterface`
`37`	`33`	`{`
`38`		`- $this->rejection = $rejection;`
`39`		`-`
`40`	`34`	`return $this;`
`41`	`35`	`}`
`42`	`36`
`43`	`37`	`public function withState(Node\Expr $state): StepBuilderInterface`
`44`	`38`	`{`
`45`		`- $this->state = $state;`
`46`		`-`
`47`	`39`	`return $this;`
`48`	`40`	`}`
`49`	`41`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ class Extractor implements StepRepositoryInterface`
`14`	`14`
`15`	`15`	`public function __construct(private SQL\Builder\Extractor $builder)`
`16`	`16`	`{`
	`17`	`+ $this->files = [];`
	`18`	`+ $this->packages = [];`
`17`	`19`	`}`
`18`	`20`
`19`	`21`	`public function withConnection(Connection $connection): self`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ class Loader implements StepRepositoryInterface`
`14`	`14`
`15`	`15`	`public function __construct(private SQL\Builder\Loader\|SQL\Builder\ConditionalLoader $builder)`
`16`	`16`	`{`
	`17`	`+ $this->files = [];`
	`18`	`+ $this->packages = [];`
`17`	`19`	`}`
`18`	`20`
`19`	`21`	`public function withConnection(Connection $connection): self`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ class Lookup implements StepRepositoryInterface`
`14`	`14`
`15`	`15`	`public function __construct(private SQL\Builder\Lookup\|SQL\Builder\ConditionalLookup $builder)`
`16`	`16`	`{`
	`17`	`+ $this->files = [];`
	`18`	`+ $this->packages = [];`
`17`	`19`	`}`
`18`	`20`
`19`	`21`	`public function withConnection(Connection $connection): self`