Merge pull request #8 from php-etl/feature/phpstan

Feature/phpstan

Author: gplanchat

.github/workflows/actions.yml

@@ -54,7 +54,7 @@ jobs:
                 with:
                     args: --prefer-dist
                     php_version: 8.0
-
+                    php_extensions: xdebug zip
             -   name: PHPStan
                 uses: php-actions/phpstan@v2
                 with:

src/CSV/FingersCrossed/Extractor.php

@@ -27,6 +27,10 @@ public function extract(): iterable
 
         $currentLine = $this->skipLines + 1;
 
+        $columns = [];
+        $columnCount = 0;
+        $cellCount = 0;
+
         /**
          * @var int $rowIndex
          * @var Row $row

src/CSV/FingersCrossed/Loader.php

@@ -25,6 +25,9 @@ public function __construct(
         $this->logger = $logger ?? new NullLogger();
     }
 
+    /**
+     * @return \Generator
+     */
     public function load(): \Generator
     {
         $line = yield;

src/CSV/Safe/Extractor.php

@@ -27,6 +27,10 @@ public function extract(): iterable
 
         $currentLine = $this->skipLines + 1;
 
+        $columns = [];
+        $columnCount = 0;
+        $cellCount = 0;
+
         /**
          * @var int $rowIndex
          * @var Row $row

src/CSV/Safe/Loader.php

@@ -25,6 +25,9 @@ public function __construct(
         $this->logger = $logger ?? new NullLogger();
     }
 
+    /**
+     * @return \Generator
+     */
     public function load(): \Generator
     {
         $line = yield;

src/Sheet/FingersCrossed/Loader.php

@@ -24,13 +24,18 @@ public function __construct(
         private string $sheetName,
         ?LoggerInterface $logger = null
     ) {
+        /** @phpstan-ignore-next-line */
         $this->writer->getCurrentSheet()->setName($this->sheetName);
         $this->logger = $logger ?? new NullLogger();
     }
 
+    /**
+     * @return \Generator
+     */
     public function load(): \Generator
     {
         $line = yield;
+
         $this->writer->addRow(
             new Row(array_map(fn ($value) => new Cell($value), array_keys($line)), null)
         );

src/Sheet/Safe/Loader.php

@@ -24,10 +24,14 @@ public function __construct(
         private string $sheetName,
         ?LoggerInterface $logger = null
     ) {
+        /** @phpstan-ignore-next-line */
         $this->writer->getCurrentSheet()->setName($this->sheetName);
         $this->logger = $logger ?? new NullLogger();
     }
 
+    /**
+     * @return \Generator
+     */
     public function load(): \Generator
     {
         $line = yield;

tests/functional/CSV/Safe/LoaderTest.php

@@ -7,6 +7,7 @@
 use Kiboko\Component\PHPUnitExtension\PipelineAssertTrait;
 use Kiboko\Component\Flow\Spreadsheet\CSV\Safe\Loader;
 use PHPUnit\Framework\TestCase;
+use Psr\Log\Test\TestLogger;
 use Vfs\FileSystem;
 
 final class LoaderTest extends TestCase
@@ -60,4 +61,35 @@ public function testLoadCsvSuccessful()
             new Loader($this->writer)
         );
     }
+
+    public function testLoadCsvWithLogger()
+    {
+        $this->writer->openToFile('vfs://test.csv');
+
+        $this->assertPipelineLoadsLike(
+            [
+                [
+                    'first name' => 'john',
+                    'last name' => 'doe',
+                ],
+                [
+                    'first name' => 'jean',
+                    'last name' => 'dupont',
+                ],
+            ],
+            [
+                [
+                    'first name' => 'john',
+                    'last name' => 'doe',
+                ],
+                [
+                    'first name' => 'jean',
+                    'last name' => 'dupont',
+                ],
+            ],
+            new Loader($this->writer, new TestLogger())
+        );
+
+        $this->assertFileEquals(__DIR__.'/../data/users.csv', 'vfs://test.csv');
+    }
 }