Fixing PHPStan level 9 issues

Author: gplanchat

composer.lock

@@ -6,8 +6,13 @@
 
 use Kiboko\Contract\Pipeline\ExtractorInterface;
 
+/**
+ * @template Type
+ * @implements ExtractorInterface<Type>
+ */
 class ArrayExtractor implements ExtractorInterface
 {
+    /** @param non-empty-array<array-key, Type> $data */
     public function __construct(private readonly array $data)
     {
     }

src/Extractor/ArrayExtractor.php

@@ -4,11 +4,15 @@
 
 namespace Kiboko\Component\Pipeline\Extractor;
 
-use Kiboko\Component\Bucket\AcceptanceResultBucket;
 use Kiboko\Contract\Pipeline\ExtractorInterface;
 
+/**
+ * @template Type
+ * @implements ExtractorInterface<Type>
+ */
 class IteratorExtractor implements ExtractorInterface
 {
+    /** @param \Traversable<mixed, Type> $traversable */
     public function __construct(private readonly \Traversable $traversable)
     {
     }

src/Extractor/IteratorExtractor.php

@@ -4,22 +4,30 @@
 
 namespace Kiboko\Component\Pipeline;
 
+use Kiboko\Contract\Bucket\ResultBucketInterface;
+
+/**
+ * @template Type
+ */
 class GeneratorWrapper
 {
+    /** @param \Iterator<mixed, mixed> ...$iterators */
     public function rewind(\Iterator ...$iterators): void
     {
         foreach ($iterators as $iterator) {
             $iterator->rewind();
         }
     }
 
+    /** @param \Iterator<mixed, mixed> ...$iterators */
     public function next(\Iterator ...$iterators): void
     {
         foreach ($iterators as $iterator) {
             $iterator->next();
         }
     }
 
+    /** @param \Iterator<mixed, mixed> ...$iterators */
     public function valid(\Iterator ...$iterators): bool
     {
         foreach ($iterators as $iterator) {
@@ -31,6 +39,10 @@ public function valid(\Iterator ...$iterators): bool
         return true;
     }
 
+    /**
+     * @param Type $value
+     * @param \Generator<array-key, ResultBucketInterface<Type>, Type|null, void> ...$generators
+     */
     public function send($value, \Generator ...$generators): \Generator
     {
         foreach ($generators as $generator) {

src/GeneratorWrapper.php

@@ -4,9 +4,17 @@
 
 namespace Kiboko\Component\Pipeline\Loader;
 
+/**
+ * @template Type
+ *
+ * @extends StreamLoader<Type>
+ */
 final class DebugLoader extends StreamLoader
 {
-    protected function formatLine($line)
+    /**
+     * @param Type|null $line
+     */
+    protected function formatLine(mixed $line): string
     {
         return var_export($line, true).\PHP_EOL;
     }

src/IteratorLoggingWrapper.php

@@ -4,9 +4,17 @@
 
 namespace Kiboko\Component\Pipeline\Loader;
 
+/**
+ * @template Type
+ *
+ * @extends StreamLoader<Type>
+ */
 final class JSONStreamLoader extends StreamLoader
 {
-    protected function formatLine($line)
+    /**
+     * @param Type|null $line
+     */
+    protected function formatLine(mixed $line): string
     {
         return json_encode($line, \JSON_THROW_ON_ERROR).\PHP_EOL;
     }

src/Loader/DebugLoader.php

@@ -13,7 +13,7 @@
 /**
  * @template Type
  *
- * @template-implements LoaderInterface<Type>
+ * @implements LoaderInterface<Type, Type>
  */
 final readonly class LogLoader implements LoaderInterface
 {
@@ -25,8 +25,10 @@ public function __construct(private LoggerInterface $logger, private string $log
     public function load(): \Generator
     {
         $line = yield new EmptyResultBucket();
-        do {
+        /** @phpstan-ignore-next-line */
+        while (true) {
             $this->logger->log($this->logLevel, var_export($line, true));
-        } while ($line = yield new AcceptanceResultBucket($line));
+            $line = yield new AcceptanceResultBucket($line);
+        }
     }
 }

src/Loader/JSONStreamLoader.php

@@ -4,14 +4,22 @@
 
 namespace Kiboko\Component\Pipeline\Loader;
 
+/**
+ * @template Type
+ *
+ * @extends StreamLoader<Type>
+ */
 final class StderrLoader extends StreamLoader
 {
     public function __construct()
     {
         parent::__construct(\STDOUT);
     }
 
-    protected function formatLine($line)
+    /**
+     * @param Type|null $line
+     */
+    protected function formatLine(mixed $line): string
     {
         return var_export($line, true).\PHP_EOL;
     }

src/Loader/LogLoader.php

@@ -4,14 +4,22 @@
 
 namespace Kiboko\Component\Pipeline\Loader;
 
+/**
+ * @template Type
+ *
+ * @extends StreamLoader<Type>
+ */
 final class StdoutLoader extends StreamLoader
 {
     public function __construct()
     {
         parent::__construct(\STDOUT);
     }
 
-    protected function formatLine($line)
+    /**
+     * @param Type|null $line
+     */
+    protected function formatLine(mixed $line): string
     {
         return var_export($line, true).\PHP_EOL;
     }