Updated assertions

gplanchat · gplanchat · commit 0648e67fc361 · 2021-07-16T17:07:21.000+02:00
diff --git a/src/BuilderAssertTrait.php b/src/BuilderAssertTrait.php
@@ -14,7 +14,6 @@
 use PHPUnit\Framework\Constraint\IsIdentical;
 use PHPUnit\Framework\Constraint\IsInstanceOf;
 use PHPUnit\Framework\Constraint\LogicalNot;
-use PHPUnit\Framework\Constraint\UnaryOperator;
 
 trait BuilderAssertTrait
 {
@@ -55,15 +54,31 @@ protected function assertBuilderProducesExtractorNotIteratesAs(array $expected,
     protected function assertBuilderProducesPipelineExtractingLike(iterable $expected, DefaultBuilder $builder, string $message = '')
     {
         $this->assertThat($builder, new BuilderProducesCodeThat(
-            new IteratesLike($expected)
+            new IteratesLike($expected, fn ($item) => new IsEqual($item))
+        ), $message);
+    }
+
+    protected function assertBuilderProducesPipelineExtractingExactly(iterable $expected, DefaultBuilder $builder, string $message = '')
+    {
+        $this->assertThat($builder, new BuilderProducesCodeThat(
+            new IteratesLike($expected, fn ($item) => new IsIdentical($item))
         ), $message);
     }
 
     protected function assertBuilderProducesPipelineNotExtractingLike(iterable $expected, DefaultBuilder $builder, string $message = '')
     {
         $this->assertThat($builder, new LogicalNot(
             new BuilderProducesCodeThat(
-                new IteratesLike($expected)
+                new IteratesLike($expected, fn ($item) => new IsEqual($item))
+            ),
+        ), $message);
+    }
+
+    protected function assertBuilderProducesPipelineNotExtractingExactly(iterable $expected, DefaultBuilder $builder, string $message = '')
+    {
+        $this->assertThat($builder, new LogicalNot(
+            new BuilderProducesCodeThat(
+                new IteratesLike($expected, fn ($item) => new IsIdentical($item))
             ),
         ), $message);
     }
diff --git a/src/Constraint/Builder/BuilderProducesCodeThat.php b/src/Constraint/Builder/BuilderProducesCodeThat.php
@@ -1,6 +1,5 @@
 <?php
 
-
 namespace Kiboko\Component\PHPUnitExtension\Constraint\Builder;
 
 use PhpParser\Builder;
diff --git a/src/Constraint/Pipeline/IteratesLike.php b/src/Constraint/Pipeline/IteratesLike.php
@@ -3,12 +3,17 @@
 namespace Kiboko\Component\PHPUnitExtension\Constraint\Pipeline;
 
 use PHPUnit\Framework\Constraint\Constraint;
-use PHPUnit\Framework\Constraint\IsIdentical;
 
 final class IteratesLike extends Constraint
 {
-    public function __construct(private iterable $expected)
-    {
+    /** @var callable */
+    private $itemConstraintFactory;
+
+    public function __construct(
+        private iterable $expected,
+        callable $itemConstraintFactory
+    ) {
+        $this->itemConstraintFactory = $itemConstraintFactory;
     }
 
     private function asIterator(iterable $iterable): \Iterator
@@ -36,7 +41,7 @@ public function matches($other): bool
         $index = 0;
         foreach ($both as [$expectedItem, $actualItem]) {
             ++$index;
-            $constraint = new IsIdentical($expectedItem);
+            $constraint = ($this->itemConstraintFactory)($expectedItem);
             $constraint->evaluate($actualItem, sprintf("Values of Iteration #%d", $index)) !== true;
         }
 
diff --git a/src/Constraint/Pipeline/PipelineExtractsLike.php b/src/Constraint/Pipeline/PipelineExtractsLike.php
@@ -2,6 +2,10 @@
 
 namespace Kiboko\Component\PHPUnitExtension\Constraint\Pipeline;
 
+use Kiboko\Component\Pipeline\PipelineRunner;
+use Kiboko\Contract\Pipeline\ExtractorInterface;
+use Kiboko\Contract\Pipeline\NullRejection;
+use Kiboko\Contract\Pipeline\NullState;
 use PHPUnit\Framework\Constraint\Constraint;
 
 final class PipelineExtractsLike extends Constraint
@@ -31,12 +35,52 @@ private function asIterator(iterable $iterable): \Iterator
         throw new \InvalidArgumentException();
     }
 
+    private function passThroughCoroutine(): \Generator
+    {
+        $line = yield;
+        while ($line = yield $line);
+    }
+
     public function matches($other): bool
     {
         $both = new \MultipleIterator(\MultipleIterator::MIT_NEED_ANY);
 
         $both->attachIterator($this->asIterator($this->expected));
-        $both->attachIterator($this->asIterator($other->extract()));
+
+        if (!$other instanceof ExtractorInterface) {
+            $this->fail($other, strtr('Expected an instance of %expected%, but got %actual%.', [
+                '%expected%' => ExtractorInterface::class,
+                '%actual%' => get_debug_type($other),
+            ]));
+        }
+
+        $runner = new PipelineRunner(null);
+        $extract = $other->extract();
+        if (is_array($extract)) {
+            $iterator = $runner->run(
+                new \ArrayIterator($extract),
+                $this->passThroughCoroutine(),
+                new NullRejection(),
+                new NullState(),
+            );
+        } elseif ($extract instanceof \Iterator) {
+            $iterator = $runner->run(
+                $extract,
+                $this->passThroughCoroutine(),
+                new NullRejection(),
+                new NullState(),
+            );
+        } elseif ($extract instanceof \Traversable) {
+            $iterator = $runner->run(
+                new \IteratorIterator($extract),
+                $this->passThroughCoroutine(),
+                new NullRejection(),
+                new NullState(),
+            );
+        } else {
+            throw new \RuntimeException('Invalid data source, expecting array or Traversable.');
+        }
+        $both->attachIterator($iterator);
 
         $index = 0;
         foreach ($both as [$expectedItem, $actualItem]) {
diff --git a/src/Constraint/Pipeline/PipelineLoadsLike.php b/src/Constraint/Pipeline/PipelineLoadsLike.php
@@ -55,7 +55,12 @@ public function matches($other): bool
             $iterator = new \AppendIterator();
 
             $iterator->append(
-                $runner->run($this->asIterator($this->source), $other->load(), new NullRejection(), new NullState())
+                $runner->run(
+                    $this->asIterator($this->source),
+                    $other->load(),
+                    new NullRejection(),
+                    new NullState(),
+                )
             );
             $iterator->append(
                 $runner->run(
@@ -65,11 +70,16 @@ public function matches($other): bool
                         yield $other->flush();
                     })(),
                     new NullRejection(),
-                    new NullState()
+                    new NullState(),
                 )
             );
         } else {
-            $iterator = $runner->run($this->asIterator($this->source), $other->load(), new NullRejection(), new NullState());
+            $iterator = $runner->run(
+                $this->asIterator($this->source),
+                $other->load(),
+                new NullRejection(),
+                new NullState(),
+            );
         }
         $both->attachIterator($iterator);
 
diff --git a/src/Constraint/Pipeline/PipelineTransformsLike.php b/src/Constraint/Pipeline/PipelineTransformsLike.php
@@ -55,7 +55,12 @@ public function matches($other): bool
             $iterator = new \AppendIterator();
 
             $iterator->append(
-                $runner->run($this->asIterator($this->source), $other->transform(), new NullRejection(), new NullState())
+                $runner->run(
+                    $this->asIterator($this->source),
+                    $other->transform(),
+                    new NullRejection(),
+                    new NullState(),
+                )
             );
             $iterator->append(
                 $runner->run(
@@ -65,11 +70,16 @@ public function matches($other): bool
                         yield $other->flush();
                     })(),
                     new NullRejection(),
-                    new NullState()
+                    new NullState(),
                 )
             );
         } else {
-            $iterator = $runner->run($this->asIterator($this->source), $other->transform(), new NullRejection(), new NullState());
+            $iterator = $runner->run(
+                $this->asIterator($this->source),
+                $other->transform(),
+                new NullRejection(),
+                new NullState(),
+            );
         }
         $both->attachIterator($iterator);
 
diff --git a/src/PipelineAssertTrait.php b/src/PipelineAssertTrait.php
@@ -22,13 +22,25 @@ abstract public static function assertThat($value, Constraint $constraint, strin
 
     protected function assertDoesIterateLike(iterable $expected, iterable $actual, $message = '')
     {
-        $this->assertThat($actual, new IteratesLike($expected), $message);
+        $this->assertThat($actual, new IteratesLike($expected, fn ($item) => new IsEqual($item)), $message);
+    }
+
+    protected function assertDoesIterateExactly(iterable $expected, iterable $actual, $message = '')
+    {
+        $this->assertThat($actual, new IteratesLike($expected, fn ($item) => new IsIdentical($item)), $message);
     }
 
     protected function assertDoesNotIterateLike(iterable $expected, iterable $actual, $message = '')
     {
         $this->assertThat($actual, new LogicalNot(
-            new IteratesLike($expected),
+            new IteratesLike($expected, fn ($item) => new IsEqual($item)),
+        ), $message);
+    }
+
+    protected function assertDoesNotIterateExactly(iterable $expected, iterable $actual, $message = '')
+    {
+        $this->assertThat($actual, new LogicalNot(
+            new IteratesLike($expected, fn ($item) => new IsIdentical($item)),
         ), $message);
     }
 

-Original file line number
+Diff line change
@@ @@ -1,6 +1,5 @@ @@
 <?php
+-
 namespace Kiboko\Component\PHPUnitExtension\Constraint\Builder;
 use PhpParser\Builder;