Skip to content

Commit d0c9b87

Browse files
committed
Updated lookups
1 parent 690e01a commit d0c9b87

File tree

3 files changed

+66
-72
lines changed

3 files changed

+66
-72
lines changed

src/CategoryLookup.php

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -22,32 +22,30 @@ public function transform(): \Generator
2222
$bucket = new ComplexResultBucket();
2323
$output = $line;
2424

25-
(function ($input, $bucket) use ($output) {
26-
try {
27-
$lookup = $this->client->catalogCategoryAttributeOptionManagementV1GetItemsGet(
28-
attributeCode: $input["Product_Category"],
29-
);
30-
31-
if (!$lookup instanceof \Kiboko\Magento\V2_1\Model\EavDataAttributeOptionInterface
32-
&& !$lookup instanceof \Kiboko\Magento\V2_2\Model\EavDataAttributeOptionInterface
33-
&& !$lookup instanceof \Kiboko\Magento\V2_3\Model\EavDataAttributeOptionInterface
34-
&& !$lookup instanceof \Kiboko\Magento\V2_4\Model\EavDataAttributeOptionInterface
35-
) {
36-
return;
37-
}
38-
} catch (\RuntimeException $exception) {
39-
$this->logger->warning($exception->getMessage(), ['exception' => $exception, 'item' => $input]);
40-
$bucket->reject($input);
25+
try {
26+
$lookup = $this->client->catalogCategoryAttributeOptionManagementV1GetItemsGet(
27+
attributeCode: $line["Product_Category"],
28+
);
29+
30+
if (!$lookup instanceof \Kiboko\Magento\V2_1\Model\EavDataAttributeOptionInterface
31+
&& !$lookup instanceof \Kiboko\Magento\V2_2\Model\EavDataAttributeOptionInterface
32+
&& !$lookup instanceof \Kiboko\Magento\V2_3\Model\EavDataAttributeOptionInterface
33+
&& !$lookup instanceof \Kiboko\Magento\V2_4\Model\EavDataAttributeOptionInterface
34+
) {
4135
return;
4236
}
43-
44-
$output = (function () use ($lookup, $output) {
45-
$output['Product_Category'] = $lookup->getLabel();
46-
return $output;
47-
})();
48-
49-
$bucket->accept($output);
50-
})($line, $bucket);
37+
} catch (\RuntimeException $exception) {
38+
$this->logger->warning($exception->getMessage(), ['exception' => $exception, 'item' => $line]);
39+
$bucket->reject($line);
40+
return;
41+
}
42+
43+
$output = (function () use ($lookup, $output) {
44+
$output['Product_Category'] = $lookup->getLabel();
45+
return $output;
46+
})();
47+
48+
$bucket->accept($output);
5149
} while ($line = (yield $bucket));
5250
}
5351
}

src/CollectionLookup.php

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -22,32 +22,30 @@ public function transform(): \Generator
2222
$bucket = new ComplexResultBucket();
2323
$output = $line;
2424

25-
(function ($input, $bucket) use ($output) {
26-
try {
27-
$lookup = $this->client->catalogCategoryAttributeOptionManagementV1GetItemsGet(
28-
attributeCode: $input["Collection"],
29-
);
30-
31-
if (!$lookup instanceof \Kiboko\Magento\V2_1\Model\EavDataAttributeOptionInterface
32-
&& !$lookup instanceof \Kiboko\Magento\V2_2\Model\EavDataAttributeOptionInterface
33-
&& !$lookup instanceof \Kiboko\Magento\V2_3\Model\EavDataAttributeOptionInterface
34-
&& !$lookup instanceof \Kiboko\Magento\V2_4\Model\EavDataAttributeOptionInterface
35-
) {
36-
return;
37-
}
38-
} catch (\RuntimeException $exception) {
39-
$this->logger->warning($exception->getMessage(), ['exception' => $exception, 'item' => $input]);
40-
$bucket->reject($input);
25+
try {
26+
$lookup = $this->client->catalogCategoryAttributeOptionManagementV1GetItemsGet(
27+
attributeCode: $line["Collection"],
28+
);
29+
30+
if (!$lookup instanceof \Kiboko\Magento\V2_1\Model\EavDataAttributeOptionInterface
31+
&& !$lookup instanceof \Kiboko\Magento\V2_2\Model\EavDataAttributeOptionInterface
32+
&& !$lookup instanceof \Kiboko\Magento\V2_3\Model\EavDataAttributeOptionInterface
33+
&& !$lookup instanceof \Kiboko\Magento\V2_4\Model\EavDataAttributeOptionInterface
34+
) {
4135
return;
4236
}
43-
44-
$output = (function () use ($lookup, $output) {
45-
$output['Collection'] = $lookup->getLabel();
46-
return $output;
47-
})();
48-
49-
$bucket->accept($output);
50-
})($line, $bucket);
37+
} catch (\RuntimeException $exception) {
38+
$this->logger->warning($exception->getMessage(), ['exception' => $exception, 'item' => $line]);
39+
$bucket->reject($line);
40+
return;
41+
}
42+
43+
$output = (function () use ($lookup, $output) {
44+
$output['Collection'] = $lookup->getLabel();
45+
return $output;
46+
})();
47+
48+
$bucket->accept($output);
5149
} while ($line = (yield $bucket));
5250
}
5351
}

src/FamilyLookup.php

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -22,32 +22,30 @@ public function transform(): \Generator
2222
$bucket = new ComplexResultBucket();
2323
$output = $line;
2424

25-
(function ($input, $bucket) use ($output) {
26-
try {
27-
$lookup = $this->client->catalogCategoryAttributeOptionManagementV1GetItemsGet(
28-
attributeCode: $input["Famille_de_Produit"],
29-
);
30-
31-
if (!$lookup instanceof \Kiboko\Magento\V2_1\Model\EavDataAttributeOptionInterface
32-
&& !$lookup instanceof \Kiboko\Magento\V2_2\Model\EavDataAttributeOptionInterface
33-
&& !$lookup instanceof \Kiboko\Magento\V2_3\Model\EavDataAttributeOptionInterface
34-
&& !$lookup instanceof \Kiboko\Magento\V2_4\Model\EavDataAttributeOptionInterface
35-
) {
36-
return;
37-
}
38-
} catch (\RuntimeException $exception) {
39-
$this->logger->warning($exception->getMessage(), ['exception' => $exception, 'item' => $input]);
40-
$bucket->reject($input);
25+
try {
26+
$lookup = $this->client->catalogCategoryAttributeOptionManagementV1GetItemsGet(
27+
attributeCode: $line["Famille_de_Produit"],
28+
);
29+
30+
if (!$lookup instanceof \Kiboko\Magento\V2_1\Model\EavDataAttributeOptionInterface
31+
&& !$lookup instanceof \Kiboko\Magento\V2_2\Model\EavDataAttributeOptionInterface
32+
&& !$lookup instanceof \Kiboko\Magento\V2_3\Model\EavDataAttributeOptionInterface
33+
&& !$lookup instanceof \Kiboko\Magento\V2_4\Model\EavDataAttributeOptionInterface
34+
) {
4135
return;
4236
}
43-
44-
$output = (function () use ($lookup, $output) {
45-
$output['Famille_de_Produit'] = $lookup->getLabel();
46-
return $output;
47-
})();
48-
49-
$bucket->accept($output);
50-
})($line, $bucket);
37+
} catch (\RuntimeException $exception) {
38+
$this->logger->warning($exception->getMessage(), ['exception' => $exception, 'item' => $line]);
39+
$bucket->reject($line);
40+
return;
41+
}
42+
43+
$output = (function () use ($lookup, $output) {
44+
$output['Famille_de_Produit'] = $lookup->getLabel();
45+
return $output;
46+
})();
47+
48+
$bucket->accept($output);
5149
} while ($line = (yield $bucket));
5250
}
5351
}

0 commit comments

Comments
 (0)