Fixed multiple files loader, updated its name and updated its tests

Author: sebprt

src/Builder/MultipleFileLoader.php src/Builder/MultipleFilesLoader.phpsrc/Builder/MultipleFileLoader.php renamed to src/Builder/MultipleFilesLoader.php

@@ -5,7 +5,7 @@
 use Kiboko\Contract\Configurator\StepBuilderInterface;
 use PhpParser\Node;
 
-final class MultipleFileLoader implements StepBuilderInterface
+final class MultipleFilesLoader implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
     private ?Node\Expr $rejection;
@@ -217,7 +217,7 @@ class: new Node\Name\FullyQualified('SplFileObject'),
                                     new Node\Stmt\Expression(
                                         expr: new Node\Expr\Assign(
                                             var: new Node\Expr\Variable('readLines'),
-                                            expr: new Node\Scalar\LNumber(1)
+                                            expr: new Node\Scalar\LNumber(0)
                                         )
                                     ),
                                     new Node\Stmt\Expression(
@@ -260,7 +260,7 @@ class: new Node\Name\FullyQualified('SplFileObject'),
                                                         new Node\Stmt\Expression(
                                                             new Node\Expr\Assign(
                                                                 new Node\Expr\Variable('readLines'),
-                                                                new Node\Scalar\LNumber(1),
+                                                                new Node\Scalar\LNumber(0),
                                                             ),
                                                         ),
                                                     ],

src/Factory/Loader.php

@@ -53,7 +53,7 @@ public function validate(array $config): bool
     public function compile(array $config): Repository\Loader
     {
         if (array_key_exists('max_lines', $config)) {
-            $loader = new CSV\Builder\MultipleFileLoader(
+            $loader = new CSV\Builder\MultipleFilesLoader(
                 filePath: compileValueWhenExpression($this->interpreter, $config['file_path'], 'index'),
                 maxLines: compileValueWhenExpression($this->interpreter, $config['max_lines']),
                 delimiter: array_key_exists('delimiter', $config) ? compileValueWhenExpression($this->interpreter, $config['delimiter']) : null,

src/Factory/Repository/Loader.php

@@ -9,13 +9,13 @@ final class Loader implements Configurator\StepRepositoryInterface
 {
     use RepositoryTrait;
 
-    public function __construct(private CSV\Builder\Loader|CSV\Builder\MultipleFileLoader $builder)
+    public function __construct(private CSV\Builder\Loader|CSV\Builder\MultipleFilesLoader $builder)
     {
         $this->files = [];
         $this->packages = [];
     }
 
-    public function getBuilder(): CSV\Builder\Loader|CSV\Builder\MultipleFileLoader
+    public function getBuilder(): CSV\Builder\Loader|CSV\Builder\MultipleFilesLoader
     {
         return $this->builder;
     }

tests/functional/Builder/MultipleFilesLoaderTest.php

@@ -33,17 +33,19 @@ public function testWithoutOptions(): void
             firstname,lastname
             Pierre,Dupont
             John,Doe
+            Frank,O'hara
             
             CSV);
 
         file_put_contents('vfs://expected-2.csv', <<<CSV
             firstname,lastname
-            Frank,O'hara
             Hiroko,Froncillo
+            Marlon,Botz
+            Billy,Hess
             
             CSV);
 
-        $loader = new Builder\MultipleFileLoader(
+        $loader = new Builder\MultipleFilesLoader(
             filePath: compileExpression(new \functional\Kiboko\Plugin\CSV\ExpressionLanguage\ExpressionLanguage(), new Expression('format("vfs://SKU_%06d.csv", index)'), 'index'),
             maxLines: new Node\Scalar\LNumber(3)
         );
@@ -65,7 +67,19 @@ public function testWithoutOptions(): void
                 [
                     'firstname' => 'Hiroko',
                     'lastname' => 'Froncillo',
-                ]
+                ],
+                [
+                    'firstname' => 'Marlon',
+                    'lastname' => 'Botz',
+                ],
+                [
+                    'firstname' => 'Billy',
+                    'lastname' => 'Hess',
+                ],
+                [
+                    'firstname' => 'Henry',
+                    'lastname' => 'Sellers',
+                ],
             ],
             [
                 [
@@ -83,7 +97,19 @@ public function testWithoutOptions(): void
                 [
                     'firstname' => 'Hiroko',
                     'lastname' => 'Froncillo',
-                ]
+                ],
+                [
+                    'firstname' => 'Marlon',
+                    'lastname' => 'Botz',
+                ],
+                [
+                    'firstname' => 'Billy',
+                    'lastname' => 'Hess',
+                ],
+                [
+                    'firstname' => 'Henry',
+                    'lastname' => 'Sellers',
+                ],
             ],
             $loader,
         );