Fixed "Property is never read, only written" + made abstract class

Author: sebprt

src/Builder/Extractor.php

@@ -10,8 +10,6 @@
 final class Extractor implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
 
     public function __construct(
         private ?Node\Expr $filePath,
@@ -22,8 +20,6 @@ public function __construct(
         private bool $safeMode = true,
     ) {
         $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
     }
 
     public function withFilePath(Node\Expr $filePath): self
@@ -70,15 +66,11 @@ public function withLogger(Node\Expr $logger): self
 
     public function withRejection(Node\Expr $rejection): self
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): self
     {
-        $this->state = $state;
-
         return $this;
     }
 

src/Builder/Loader.php

@@ -10,8 +10,6 @@
 final class Loader implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
 
     public function __construct(
         private ?Node\Expr $filePath,
@@ -22,8 +20,6 @@ public function __construct(
         private bool $safeMode = true,
     ) {
         $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
     }
 
     public function withFilePath(Node\Expr $filePath): self
@@ -70,15 +66,11 @@ public function withLogger(Node\Expr $logger): self
 
     public function withRejection(Node\Expr $rejection): self
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): self
     {
-        $this->state = $state;
-
         return $this;
     }
 

src/Builder/MultipleFilesLoader.php

@@ -10,8 +10,6 @@
 final class MultipleFilesLoader implements StepBuilderInterface
 {
     private ?Node\Expr $logger;
-    private ?Node\Expr $rejection;
-    private ?Node\Expr $state;
 
     public function __construct(
         private ?Node\Expr $filePath,
@@ -23,8 +21,6 @@ public function __construct(
         private bool $safeMode = true,
     ) {
         $this->logger = null;
-        $this->rejection = null;
-        $this->state = null;
     }
 
     public function withFilePath(Node\Expr $filePath): self
@@ -34,13 +30,6 @@ public function withFilePath(Node\Expr $filePath): self
         return $this;
     }
 
-    public function withPattern(Node\Expr $pattern): self
-    {
-        $this->pattern = $pattern;
-
-        return $this;
-    }
-
     public function withMaxLines(Node\Expr $maxLines): self
     {
         $this->maxLines = $maxLines;
@@ -85,15 +74,11 @@ public function withLogger(Node\Expr $logger): self
 
     public function withRejection(Node\Expr $rejection): self
     {
-        $this->rejection = $rejection;
-
         return $this;
     }
 
     public function withState(Node\Expr $state): self
     {
-        $this->state = $state;
-
         return $this;
     }
 

src/Configuration.php

@@ -15,6 +15,8 @@ public function getConfigTreeBuilder(): TreeBuilder
         $loader = new Configuration\Loader();
 
         $builder = new TreeBuilder('csv');
+
+        /* @phpstan-ignore-next-line */
         $builder->getRootNode()
             ->validate()
                 ->ifTrue(function (array $value) {

src/Configuration/Extractor.php

@@ -15,6 +15,7 @@ public function getConfigTreeBuilder(): TreeBuilder
     {
         $builder = new TreeBuilder('extractor');
 
+        /* @phpstan-ignore-next-line */
         $builder->getRootNode()
             ->children()
                 ->scalarNode('file_path')

src/Configuration/Loader.php

@@ -15,6 +15,7 @@ public function getConfigTreeBuilder(): TreeBuilder
     {
         $builder = new TreeBuilder('loader');
 
+        /* @phpstan-ignore-next-line */
         $builder->getRootNode()
             ->children()
                 ->scalarNode('file_path')

tests/functional/Builder/ExtractorTest.php

@@ -6,7 +6,7 @@
 use Kiboko\Plugin\Log;
 use PhpParser\Node;
 
-final class ExtractorTest extends BuilderTestCase
+abstract class ExtractorTest extends BuilderTestCase
 {
     public function testWithoutOptions(): void
     {

tests/functional/Builder/LoaderTest.php

@@ -6,7 +6,7 @@
 use Kiboko\Plugin\Log;
 use PhpParser\Node;
 
-final class LoaderTest extends BuilderTestCase
+abstract class LoaderTest extends BuilderTestCase
 {
     public function testWithoutOptions(): void
     {

tests/functional/Builder/MultipleFilesLoaderTest.php

@@ -9,7 +9,7 @@
 use Vfs\FileSystem;
 use function Kiboko\Component\SatelliteToolbox\Configuration\compileExpression;
 
-final class MultipleFilesLoaderTest extends BuilderTestCase
+abstract class MultipleFilesLoaderTest extends BuilderTestCase
 {
     use PipelineAssertTrait;