improved twitch code. fixes #384

oscarotero · oscarotero · commit b3638145b7aa · 2020-09-23T23:08:52.000+02:00
diff --git a/README.md b/README.md
@@ -330,10 +330,10 @@ If you need to pass settings to your detectors, you can use the `setSettings` me
 //Create the extractor
 $info = $embed->get($url);
 
-//Pass settings for example.com site
-if ($info->getUri()->getHost() === 'example.com') {
-    $info->setSettings(['example_api_key' => 'xxx']);
-}
+$info->setSettings([
+    'oembed:query_parameters' => []  //Extra parameters send to oembed
+    'twitch:parent' => 'example.com' //Required to embed twitch videos as iframe
+]);
 ```
 
 Note: The built-in detectors does not require settings. This feature is only for convenience if you create a specific detector that requires settings.
diff --git a/demo/index.php b/demo/index.php
@@ -194,6 +194,9 @@ function printCode(?string $code, bool $asHtml = true): void
                     'Cache-Control' => 'max-age=0,no-cache',
                 ]);
                 $info = $embed->get(getUrl());
+                $info->setSettings([
+                    'twitch:parent' => $_SERVER['SERVER_NAME'] === 'localhost' ? null : $_SERVER['SERVER_NAME']
+                ]);
             } catch (Exception $exception) {
                 echo '<pre>';
                 echo $exception;
diff --git a/src/Adapters/Twitch/Detectors/Code.php b/src/Adapters/Twitch/Detectors/Code.php
@@ -18,14 +18,19 @@ public function detect(): ?EmbedCode
     private function fallback(): ?EmbedCode
     {
         $path = $this->extractor->getUri()->getPath();
+        $parent = $this->extractor->getSetting('twitch:parent');
 
         if ($id = self::getVideoId($path)) {
-            $code = self::generateCode(['video' => "v{$id}"]);
+            $code = $parent 
+                ? self::generateIframeCode(['id' => $id, 'parent' => $parent]) 
+                : self::generateJsCode('video', $id);
             return new EmbedCode($code, 620, 378);
         }
 
         if ($id = self::getChannelId($path)) {
-            $code = self::generateCode(['channel' => $id]);
+            $code = $parent
+                ? self::generateIframeCode(['channel' => $id, 'parent' => $parent]) 
+                : self::generateJsCode('channel', $id);
             return new EmbedCode($code, 620, 378);
         }
 
@@ -50,7 +55,7 @@ private static function getChannelId(string $path): ?string
         return null;
     }
 
-    private static function generateCode(array $params): string
+    private static function generateIframeCode(array $params): string
     {
         $query = http_build_query(['autoplay' => 'false'] + $params);
 
@@ -63,4 +68,15 @@ private static function generateCode(array $params): string
             'width' => 620,
         ]);
     }
+
+    private static function generateJsCode($key, $value)
+    {
+        return <<<HTML
+        <div id="twitch-embed"></div>
+        <script src="https://player.twitch.tv/js/embed/v1.js"></script>
+        <script type="text/javascript">
+            new Twitch.Player("twitch-embed", { {$key}: "{$value}" });
+        </script>
+        HTML;
+    }
 }
