diff --git a/src/extensionsIntegrated/Phoenix-live-preview/main.js b/src/extensionsIntegrated/Phoenix-live-preview/main.js index a01286d3f..b28c84eaa 100644 --- a/src/extensionsIntegrated/Phoenix-live-preview/main.js +++ b/src/extensionsIntegrated/Phoenix-live-preview/main.js @@ -269,7 +269,11 @@ define(function (require, exports, module) { $statusOverlayMessage.text(textMessage); $statusOverlay.data("status", status); - $statusOverlay.removeClass("forced-hidden"); + + // @devansh - commenting this out to not show the status overlays, need to fix later + // the issue is that status overlay - conneting status was never getting removed on devices with + // slow connections or sites with heavy videos... + // $statusOverlay.removeClass("forced-hidden"); } /** diff --git a/test/spec/LiveDevelopmentMultiBrowser-test.js b/test/spec/LiveDevelopmentMultiBrowser-test.js index 1a6a0b694..30bc999ee 100644 --- a/test/spec/LiveDevelopmentMultiBrowser-test.js +++ b/test/spec/LiveDevelopmentMultiBrowser-test.js @@ -343,36 +343,37 @@ define(function (require, exports, module) { await endPreviewSession(); }, 30000); - it("should show error banner if there is syntax error in html", async function () { - let savedText, - curDoc; - - await awaitsForDone(SpecRunnerUtils.openProjectFiles(["simple1.html"]), - "SpecRunnerUtils.openProjectFiles simple1.html"); - - await waitsForLiveDevelopmentToOpen(); - - curDoc = DocumentManager.getCurrentDocument(); - savedText = curDoc.getText(); - // split file in half to and add syntax error then see if error banner shows up - const mid = Math.ceil(savedText.length / 2); - curDoc.setText(savedText.slice(0, mid)); - - await awaitsFor( - function isBannerVisible() { - return testWindow.$(".live-preview-status-overlay").is(":visible") && - testWindow.$(".live-preview-status-overlay").text() - .includes(Strings.LIVE_DEV_STATUS_TIP_SYNC_ERROR); - }, - "waiting for syntax error banner to appear", - 5000, - 50 - ); - - curDoc.setText(savedText); - - await endPreviewSession(); - }, 30000); + // @devansh: commenting out this test as we are not doing status overlays for now + // it("should show error banner if there is syntax error in html", async function () { + // let savedText, + // curDoc; + // + // await awaitsForDone(SpecRunnerUtils.openProjectFiles(["simple1.html"]), + // "SpecRunnerUtils.openProjectFiles simple1.html"); + // + // await waitsForLiveDevelopmentToOpen(); + // + // curDoc = DocumentManager.getCurrentDocument(); + // savedText = curDoc.getText(); + // // split file in half to and add syntax error then see if error banner shows up + // const mid = Math.ceil(savedText.length / 2); + // curDoc.setText(savedText.slice(0, mid)); + // + // await awaitsFor( + // function isBannerVisible() { + // return testWindow.$(".live-preview-status-overlay").is(":visible") && + // testWindow.$(".live-preview-status-overlay").text() + // .includes(Strings.LIVE_DEV_STATUS_TIP_SYNC_ERROR); + // }, + // "waiting for syntax error banner to appear", + // 5000, + // 50 + // ); + // + // curDoc.setText(savedText); + // + // await endPreviewSession(); + // }, 30000); it("should make CSS-relative URLs absolute", async function () { var localText,