PostgreSQL 18 support

[devrimgunduz]

Hi,

sqlite_fdw 2.5.0 fails to build against PostgreSQL 18 beta 2. The errors are below. Can you please take a look? Thanks! Devrim

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -Wmissing-variable-declarations -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fPIC -fvisibility=hidden -I. -I./ -I/usr/pgsql-18/include/server -I/usr/pgsql-18/include/internal    -D_GNU_SOURCE -I/usr/include/libxml2 -DWITH_GZFILEOP  -I/usr/include  -c -o deparse.o deparse.c
deparse.c: In function ‘sqlite_is_foreign_pathkey’:
deparse.c:392:80: error: ‘PathKey’ has no member named ‘pk_strategy’
  392 |                                                                         pathkey->pk_strategy);
      |                                                                                ^~
In file included from /usr/pgsql-18/include/server/postgres.h:49,
                 from deparse.c:13:
deparse.c:395:41: error: ‘PathKey’ has no member named ‘pk_strategy’
  395 |                                  pathkey->pk_strategy, em->em_datatype, em->em_datatype,
      |                                         ^~
/usr/pgsql-18/include/server/utils/elog.h:147:25: note: in definition of macro ‘ereport_domain’
  147 |                         __VA_ARGS__, errfinish(__FILE__, __LINE__, __func__); \
      |                         ^~~~~~~~~~~
/usr/pgsql-18/include/server/utils/elog.h:240:9: note: in expansion of macro ‘ereport’
  240 |         ereport(elevel, errmsg_internal(__VA_ARGS__))
      |         ^~~~~~~
deparse.c:394:25: note: in expansion of macro ‘elog’
  394 |                         elog(ERROR, "missing operator %d(%u,%u) in opfamily %u",
      |                         ^~~~
/usr/pgsql-18/include/server/utils/elog.h:147:36: warning: left-hand operand of comma expression has no effect [-Wunused-value]
  147 |                         __VA_ARGS__, errfinish(__FILE__, __LINE__, __func__); \
      |                                    ^
/usr/pgsql-18/include/server/utils/elog.h:164:9: note: in expansion of macro ‘ereport_domain’
  164 |         ereport_domain(elevel, TEXTDOMAIN, __VA_ARGS__)
      |         ^~~~~~~~~~~~~~
/usr/pgsql-18/include/server/utils/elog.h:240:9: note: in expansion of macro ‘ereport’
  240 |         ereport(elevel, errmsg_internal(__VA_ARGS__))
      |         ^~~~~~~
deparse.c:394:25: note: in expansion of macro ‘elog’
  394 |                         elog(ERROR, "missing operator %d(%u,%u) in opfamily %u",
      |                         ^~~~
deparse.c: In function ‘sqlite_append_order_by_clause’:
deparse.c:3873:80: error: ‘PathKey’ has no member named ‘pk_strategy’
 3873 |                                                                         pathkey->pk_strategy);
      |                                                                                ^~
deparse.c:3876:41: error: ‘PathKey’ has no member named ‘pk_strategy’
 3876 |                                  pathkey->pk_strategy, em->em_datatype, em->em_datatype,
      |                                         ^~
/usr/pgsql-18/include/server/utils/elog.h:147:25: note: in definition of macro ‘ereport_domain’
  147 |                         __VA_ARGS__, errfinish(__FILE__, __LINE__, __func__); \
      |                         ^~~~~~~~~~~
/usr/pgsql-18/include/server/utils/elog.h:240:9: note: in expansion of macro ‘ereport’
  240 |         ereport(elevel, errmsg_internal(__VA_ARGS__))
      |         ^~~~~~~
deparse.c:3875:25: note: in expansion of macro ‘elog’
 3875 |                         elog(ERROR, "missing operator %d(%u,%u) in opfamily %u",
      |                         ^~~~
/usr/pgsql-18/include/server/utils/elog.h:147:36: warning: left-hand operand of comma expression has no effect [-Wunused-value]
  147 |                         __VA_ARGS__, errfinish(__FILE__, __LINE__, __func__); \
      |                                    ^
/usr/pgsql-18/include/server/utils/elog.h:164:9: note: in expansion of macro ‘ereport_domain’
  164 |         ereport_domain(elevel, TEXTDOMAIN, __VA_ARGS__)
      |         ^~~~~~~~~~~~~~
/usr/pgsql-18/include/server/utils/elog.h:240:9: note: in expansion of macro ‘ereport’
  240 |         ereport(elevel, errmsg_internal(__VA_ARGS__))
      |         ^~~~~~~
deparse.c:3875:25: note: in expansion of macro ‘elog’
 3875 |                         elog(ERROR, "missing operator %d(%u,%u) in opfamily %u",
      |                         ^~~~
deparse.c:3900:64: error: ‘PathKey’ has no member named ‘pk_strategy’
 3900 |                         if (!pathkey->pk_nulls_first && pathkey->pk_strategy == BTLessStrategyNumber)
      |                                                                ^~
deparse.c:3902:68: error: ‘PathKey’ has no member named ‘pk_strategy’
 3902 |                         else if (pathkey->pk_nulls_first && pathkey->pk_strategy != BTLessStrategyNumber)
      |                                                                

[devrimgunduz]

Just a heads-up: PostgreSQL 18 RC1 will be out this Thursday (4 September). GA is currently planned at 25 September

[mkgrgis]

@devrimgunduz , after 2025-04 there was no activity in any pgspider repository. I can merge all new features with the same CI and PostgreSQL 18 support in my fork. Will this enough?

[devrimgunduz]

Hi @mkgrgis , sure, why not?

[mkgrgis]

I am on FDW vacations, @devrimgunduz , but there is a plan to release PG18 support in my fork near 2025-10-20.

[mkgrgis]

Hello, @devrimgunduz! I have successfully merged all of new features and adopted code to compilable for PG18. Now I have some difference in PG18 tests, but cannot decide if this is normal. Unfortunately I am still middle contributor and junior maintainer for this FDW.
Unfortunately powerful pgspider team with 15+ FDWs is not active now, hence it will be good to have some candidates for senior maintainer of this FDW. Could you help with such candidates inside of PostgreSQL community?