Skip to content

Commit b07f66c

Browse files
committed
Sync libzip target name
1 parent 1db3b9b commit b07f66c

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

cmake/cmake/modules/PHP/Package/LibXml2.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
#[=============================================================================[
22
# PHP/Package/LibXml2
33
4-
Finds and downloads the `libxml2` library:
4+
Finds or downloads the libxml2 library:
55
66
```cmake
77
include(PHP/Package/LibXml2)
88
```
99
10-
This module first tries to find the `libxml2` library on the system. If not
11-
successful it tries to download it from the upstream source and builds it
12-
together with the PHP build.
10+
This module first tries to find the libxml2 library on the system. If not found
11+
it tries to download it from the upstream source and builds it together
12+
with the PHP build.
1313
1414
See: https://cmake.org/cmake/help/latest/module/FindLibXml2.html
1515

cmake/cmake/modules/PHP/Package/Oniguruma.cmake

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,14 @@ Finds or downloads the Oniguruma library:
77
include(PHP/Package/Oniguruma)
88
```
99
10-
This module first tries to find the `Oniguruma` library on the system. If not
11-
successful it downloads it from the upstream source during the main project
10+
This module first tries to find the Oniguruma library on the system. If not
11+
found it downloads it from the upstream source during the main project
1212
configuration phase and then configures and builds it during the main project's
1313
build phase.
1414
15+
The `FetchContent` module is used, which provides integration with other
16+
dependency providers, such as Conan.
17+
1518
## Examples
1619
1720
Basic usage:

cmake/cmake/modules/PHP/Package/PNG.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ Finds or downloads the PNG library:
77
include(PHP/Package/PNG)
88
```
99
10-
Wrapper for finding the `PNG` library.
11-
1210
Module first tries to find the `PNG` library on the system. If not
1311
successful it tries to download it from the upstream source and builds it
1412
together with the PHP build.

cmake/cmake/modules/PHP/Package/libzip.cmake

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,22 @@
11
#[=============================================================================[
22
# PHP/Package/libzip
33
4-
Finds and downloads `libzip` library:
4+
Finds or downloads libzip library:
55
66
```cmake
77
include(PHP/Package/libzip
88
```
99
10-
This module first tries to find the `libzip` library on the system. If not
11-
successful it tries to download it from the upstream source and builds it
12-
together with the PHP build.
10+
This module first tries to find the libzip library on the system. If not found
11+
it downloads it from the upstream source and builds it together with the build.
1312
1413
## Examples
1514
1615
Basic usage:
1716
1817
```cmake
1918
include(PHP/Package/libzip
20-
target_link_libraries(php_ext_foo PRIVATE libzip::libzip)
19+
target_link_libraries(php_ext_foo PRIVATE libzip::zip)
2120
```
2221
#]=============================================================================]
2322

@@ -34,7 +33,7 @@ set(PHP_libzip_MIN_VERSION 1.7.1)
3433
set(PHP_libzip_DOWNLOAD_VERSION 1.11.4)
3534

3635
macro(php_package_libzip_find)
37-
if(TARGET libzip::libzip)
36+
if(TARGET libzip::zip)
3837
set(libzip_FOUND TRUE)
3938
get_property(libzip_DOWNLOADED GLOBAL PROPERTY _PHP_libzip_DOWNLOADED)
4039
get_property(libzip_VERSION GLOBAL PROPERTY _PHP_libzip_VERSION)
@@ -99,10 +98,10 @@ macro(_php_package_libzip_download)
9998
# Bypass missing directory error for the imported target below.
10099
file(MAKE_DIRECTORY ${INSTALL_DIR}/include)
101100

102-
add_library(libzip::libzip STATIC IMPORTED GLOBAL)
103-
add_dependencies(libzip::libzip libzip-install)
101+
add_library(libzip::zip STATIC IMPORTED GLOBAL)
102+
add_dependencies(libzip::zip libzip-install)
104103
set_target_properties(
105-
libzip::libzip
104+
libzip::zip
106105
PROPERTIES
107106
INTERFACE_INCLUDE_DIRECTORIES ${INSTALL_DIR}/include
108107
IMPORTED_LOCATION ${INSTALL_DIR}/lib/libzip${CMAKE_STATIC_LIBRARY_SUFFIX}

cmake/conanfile.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ libsodium/1.0.20
2828
libxml2/2.13.8
2929
#libxpm/3.5.17 # Build error due to missing system packages.
3030
libxslt/1.1.43
31-
#libzip/1.11.3 # Builds ok, but CMake imported target name needs to be adjusted.
31+
libzip/1.11.3
3232
#lmdb/0.9.32 # Builds ok, but CMake imported target name needs to be adjusted.
3333
#net-snmp/5.9.4 # Builds ok, but CMake imported target name needs to be adjusted.
3434
odbc/2.3.11

0 commit comments

Comments
 (0)