Skip to content

Commit fa83617

Browse files
committed
add more logs :)
1 parent 1a2e24e commit fa83617

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

cmd/manager/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ func main() {
148148
os.Exit(1)
149149
}
150150

151-
if err := mcs.Register(discovery.NewDiscoveryClientForConfigOrDie(config)); err != nil {
151+
if err := mcs.Register(discovery.NewDiscoveryClientForConfigOrDie(config), setupLog); err != nil {
152152
setupLog.Error(err, "failed to register multicluster service")
153153
os.Exit(1)
154154
}

pkg/mcs/register.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package mcs
22

33
import (
4+
"github.com/go-logr/logr"
45
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
56
"k8s.io/apimachinery/pkg/runtime"
67
"k8s.io/apimachinery/pkg/runtime/schema"
@@ -32,12 +33,13 @@ func addKnownTypes(scheme *runtime.Scheme) error {
3233
return nil
3334
}
3435

35-
func Register(dc *discovery.DiscoveryClient) error {
36+
func Register(dc *discovery.DiscoveryClient, log logr.Logger) error {
3637
resources, err := dc.ServerPreferredResources()
3738
if err != nil {
3839
// MCS is optional functionality - if discovery fails for any reason,
3940
// mark it as unavailable and continue without crashing the operator
4041
available = false
42+
log.Info("Multi-cluster services (MCS) are not available: failed to discover API resources", "error", err)
4143
return nil
4244
}
4345

@@ -55,6 +57,7 @@ outer:
5557

5658
if MCSSchemeGroupVersion.Group == "" {
5759
available = false
60+
log.Info("Multi-cluster services (MCS) are not available: ServiceExport resource not found in cluster")
5861
return nil
5962
}
6063

0 commit comments

Comments
 (0)