Skip to content

Commit cfa5f63

Browse files
committed
fix tests
1 parent 5bb63a0 commit cfa5f63

File tree

4 files changed

+31
-28
lines changed
  • e2e-tests

4 files changed

+31
-28
lines changed

e2e-tests/demand-backup-eks-credentials/run

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ compare_mongo_cmd "find" "myApp:myPass@$cluster-2.$cluster.$namespace"
7171

7272
desc 'delete backup and check if it is removed from bucket -- aws-s3'
7373
kubectl_bin delete psmdb-backup --all
74-
check_backup_deletion_aws "$backup_dest_aws"
74+
check_backup_deletion_aws "$backup_dest_aws" "/rs0/myApp.test.gz"
7575

7676
destroy $namespace
7777

e2e-tests/demand-backup-sharded/run

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,9 @@ if [ -z "$SKIP_BACKUPS_TO_AWS_GCP_AZURE" ]; then
137137
desc 'check backup and restore -- azure-blob'
138138
backup_dest_azure=$(get_backup_dest "$backup_name_azure")
139139
setup_azure_credentials
140-
check_backup_existence_azure "$backup_dest_azure" "/rs0/myApp.test.gz" | gunzip >/dev/null
141-
check_backup_existence_azure "$backup_dest_azure" "/rs1/myApp1.test.gz" | gunzip >/dev/null
142-
check_backup_existence_azure "$backup_dest_azure" "/rs2/myApp2.test.gz" | gunzip >/dev/null
140+
check_backup_existence_azure "$backup_dest_azure" "/rs0/myApp.test.gz"
141+
check_backup_existence_azure "$backup_dest_azure" "/rs1/myApp1.test.gz"
142+
check_backup_existence_azure "$backup_dest_azure" "/rs2/myApp2.test.gz"
143143
insert_data_mongos "100501" "myApp" "" "$custom_port"
144144
insert_data_mongos "100501" "myApp1" "" "$custom_port"
145145
insert_data_mongos "100501" "myApp2" "" "$custom_port"
@@ -172,9 +172,9 @@ if [[ $backup_exists -eq 1 ]]; then
172172
fi
173173

174174
if [ -z "$SKIP_BACKUPS_TO_AWS_GCP_AZURE" ]; then
175-
check_backup_deletion_aws "$backup_dest_aws"
176-
check_backup_deletion_gcs "$backup_dest_gcp"
177-
check_backup_deletion_azure "$backup_dest_azure"
175+
check_backup_deletion_aws "$backup_dest_aws" "/rs0/myApp.test.gz"
176+
check_backup_deletion_gcs "$backup_dest_gcp" "/rs0/myApp.test.gz"
177+
check_backup_deletion_azure "$backup_dest_azure" "/rs0/myApp.test.gz"
178178
fi
179179

180180
# Temporarily skipping this check
@@ -183,3 +183,4 @@ fi
183183

184184
kubectl_bin delete -f "$conf_dir/container-rc.yaml"
185185
destroy "$namespace"
186+
desc 'test passed'

e2e-tests/demand-backup/run

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ wait_backup_agent $cluster-1
188188
wait_backup_agent $cluster-2
189189

190190
if [ -z "$SKIP_BACKUPS_TO_AWS_GCP_AZURE" ]; then
191-
desc 'Check GCS pfofiles'
191+
desc 'Check GCS profiles'
192192
compare_pbm_profile_setup "some-name" "gcp-cs-s3"
193193
compare_pbm_profile_setup "some-name" "gcp-cs-sa"
194194
fi
@@ -224,24 +224,24 @@ if [ -z "$SKIP_BACKUPS_TO_AWS_GCP_AZURE" ]; then
224224
desc 'check backup and restore -- aws-s3'
225225
backup_dest_aws=$(get_backup_dest "$backup_name_aws")
226226
setup_aws_credentials
227-
check_backup_existence_aws ${backup_name_aws} '/rs0/myApp.test.gz'
227+
check_backup_existence_aws ${backup_dest_aws} '/rs0/myApp.test.gz'
228228
run_recovery_check "$backup_name_aws" "$cluster"
229229

230230
desc 'check backup and restore -- gcp-cs-s3'
231231
backup_dest_gcp_s3=$(get_backup_dest "$backup_name_gcp_s3")
232232
setup_gcs_credentials
233-
check_backup_existence_gcs ${backup_name_gcp_s3} '/rs0/myApp.test.gz'
233+
check_backup_existence_gcs ${backup_dest_gcp_s3} '/rs0/myApp.test.gz'
234234
run_recovery_check "$backup_name_gcp_s3" "$cluster"
235235

236236
desc 'check backup and restore -- gcp-cs-sa'
237237
backup_dest_gcp_sa=$(get_backup_dest "$backup_name_gcp_sa")
238-
check_backup_existence_gcs ${backup_name_gcp_sa} '/rs0/myApp.test.gz'
238+
check_backup_existence_gcs ${backup_dest_gcp_sa} '/rs0/myApp.test.gz'
239239
run_recovery_check "$backup_name_gcp_sa" "$cluster"
240240

241241
desc 'check backup and restore -- azure-blob'
242242
backup_dest_azure=$(get_backup_dest "$backup_name_azure")
243243
setup_azure_credentials
244-
check_backup_in_azure ${backup_name_azure} '/rs0/myApp.test.gz'
244+
check_backup_existence_azure ${backup_dest_azure} '/rs0/myApp.test.gz'
245245
run_recovery_check "$backup_name_azure" "$cluster"
246246
fi
247247

@@ -288,10 +288,10 @@ if [[ $backup_exists -eq 1 ]]; then
288288
fi
289289

290290
if [ -z "$SKIP_BACKUPS_TO_AWS_GCP_AZURE" ]; then
291-
check_backup_deletion_aws "$backup_dest_aws"
292-
check_backup_deletion_gcs "$backup_dest_gcp_s3"
293-
check_backup_deletion_gcs "$backup_dest_gcp_sa"
294-
check_backup_deletion_azure "$backup_dest_azure"
291+
check_backup_deletion_aws "$backup_dest_aws" "/rs0/myApp.test.gz"
292+
check_backup_deletion_gcs "$backup_dest_gcp_s3" "/rs0/myApp.test.gz"
293+
check_backup_deletion_gcs "$backup_dest_gcp_sa" "/rs0/myApp.test.gz"
294+
check_backup_deletion_azure "$backup_dest_azure" "/rs0/myApp.test.gz"
295295
fi
296296

297297
desc 'checking backup deletion without cr'
@@ -330,10 +330,10 @@ if [[ $backup_exists -eq 1 ]]; then
330330
fi
331331

332332
if [ -z "$SKIP_BACKUPS_TO_AWS_GCP_AZURE" ]; then
333-
check_backup_deletion_aws "$backup_dest_aws"
334-
check_backup_deletion_gcs "$backup_dest_gcp_s3"
335-
check_backup_deletion_gcs "$backup_dest_gcp_sa"
336-
check_backup_deletion_azure "$backup_dest_azure"
333+
check_backup_deletion_aws "$backup_dest_aws" "/rs0/myApp.test.gz"
334+
check_backup_deletion_gcs "$backup_dest_gcp_s3" "/rs0/myApp.test.gz"
335+
check_backup_deletion_gcs "$backup_dest_gcp_sa" "/rs0/myApp.test.gz"
336+
check_backup_deletion_azure "$backup_dest_azure" "/rs0/myApp.test.gz"
337337
fi
338338

339339
# Temporarily skipping this check

e2e-tests/functions

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2341,12 +2341,12 @@ function check_backup_existence_aws() {
23412341
echo "Backup was not found in bucket -- $storage_name"
23422342
exit 1
23432343
fi
2344-
echo "waiting for backup in $storage_name"
2344+
echo "waiting for backup $bucket/$key_prefix/$key in $storage_name"
23452345
sleep 10
23462346
((retry += 1))
23472347
done
23482348

2349-
echo "Backup ${key_prefix}${key} found in bucket $bucket in $storage_name"
2349+
echo "Backup $bucket/$key_prefix/$key found in $storage_name"
23502350
}
23512351

23522352
function check_backup_existence_gcs() {
@@ -2363,17 +2363,19 @@ function check_backup_existence_gcs() {
23632363
echo "Backup was not found in bucket -- $storage_name"
23642364
exit 1
23652365
fi
2366-
echo "Waiting for backup in $storage_name ($gcs_path)..."
2366+
echo "Waiting for backup $gcs_path in $storage_name"
23672367
sleep 10
23682368
((retry += 1))
23692369
done
23702370

2371-
echo "Backup found in $storage_name: $gcs_path"
2371+
echo "Backup $gcs_path found in $storage_name"
23722372
}
23732373

23742374
function check_backup_existence_azure() {
2375-
container=$(echo "$1" | cut -d'/' -f1)
2376-
blob_prefix=$(echo "$1" | cut -d'/' -f2-)
2375+
url_path=$(echo "$1" | sed 's|https://[^/]*\.blob\.core\.windows\.net/||')
2376+
container=$(echo "$url_path" | cut -d'/' -f1)
2377+
blob_prefix=$(echo "$url_path" | cut -d'/' -f2-)
2378+
23772379
blob=$2
23782380
storage_name="azure-blob"
23792381
retry=0
@@ -2385,12 +2387,12 @@ function check_backup_existence_azure() {
23852387
echo "Backup was not found in container -- $storage_name"
23862388
exit 1
23872389
fi
2388-
echo "waiting for backup in $storage_name"
2390+
echo "waiting for backup $blob_path in $storage_name"
23892391
sleep 10
23902392
((retry += 1))
23912393
done
23922394

2393-
echo "Backup ${blob_path} found in container $container in $storage_name"
2395+
echo "Backup $blob_path found in $storage_name"
23942396
}
23952397

23962398
check_backup_in_storage() {

0 commit comments

Comments
 (0)