K8SPG-893 configure LC_ALL and LANG for database containers (#1350)

* K8SPG-893 configure LC_ALL and LANG for database containers

* copy env from database to upgrade container

* fix tests

* guard with version 2.8

* fix

* set version to latest for unit test pod allow volume grow

* add only the needed env vars instead of the whole database env

* fix unit test

Author: gkech

internal/controller/pgupgrade/jobs.go

@@ -203,6 +203,20 @@ func (r *PGUpgradeReconciler) generateUpgradeJob(
 		SecurityContext: database.SecurityContext,
 		VolumeMounts:    volumeMounts, // K8SPG-254
 
+		// K8SPG-893
+		Env: []corev1.EnvVar{
+			// Critical for major upgrades to avoid lc_collate mismatches.
+			// - https://www.postgresql.org/docs/current/locale.html
+			{
+				Name:  "LC_ALL",
+				Value: "en_US.utf-8",
+			},
+			{
+				Name:  "LANG",
+				Value: "en_US.utf-8",
+			},
+		},
+
 		// Use our upgrade command and the specified image and resources.
 		Command: upgradeCommand(
 			upgrade.Spec.FromPostgresVersion,

internal/controller/pgupgrade/jobs_test.go

@@ -203,6 +203,11 @@ spec:
         - upgrade
         - "19"
         - "25"
+        env:
+        - name: LC_ALL
+          value: en_US.utf-8
+        - name: LANG
+          value: en_US.utf-8
         image: img4
         name: database
         resources:

internal/postgres/config.go

@@ -164,6 +164,21 @@ func Environment(cluster *v1beta1.PostgresCluster) []corev1.EnvVar {
 		})
 	}
 
+	if cluster.CompareVersion("2.8.0") >= 0 {
+		env = append(env, []corev1.EnvVar{
+			// Critical for major upgrades to avoid lc_collate mismatches.
+			// - https://www.postgresql.org/docs/current/locale.html
+			{
+				Name:  "LC_ALL",
+				Value: "en_US.utf-8",
+			},
+			{
+				Name:  "LANG",
+				Value: "en_US.utf-8",
+			},
+		}...)
+	}
+
 	return env
 }
 

internal/postgres/reconcile_test.go

@@ -138,6 +138,10 @@ containers:
     value: /tmp
   - name: LDAPTLS_CACERT
     value: /etc/postgres/ldap/ca.crt
+  - name: LC_ALL
+    value: en_US.utf-8
+  - name: LANG
+    value: en_US.utf-8
   imagePullPolicy: Always
   name: database
   ports:
@@ -289,6 +293,10 @@ initContainers:
     value: /tmp
   - name: LDAPTLS_CACERT
     value: /etc/postgres/ldap/ca.crt
+  - name: LC_ALL
+    value: en_US.utf-8
+  - name: LANG
+    value: en_US.utf-8
   imagePullPolicy: Always
   name: postgres-startup
   resources:
@@ -713,7 +721,7 @@ func TestInstancePodAllowVolumeGrow(t *testing.T) {
 	cluster.Spec.ImagePullPolicy = corev1.PullAlways
 	cluster.Spec.PostgresVersion = 11
 	cluster.SetLabels(map[string]string{
-		naming.LabelVersion: "2.7.0",
+		naming.LabelVersion: version.Version(),
 	})
 
 	dataVolume := new(corev1.PersistentVolumeClaim)
@@ -781,6 +789,10 @@ containers:
     value: /tmp
   - name: LDAPTLS_CACERT
     value: /etc/postgres/ldap/ca.crt
+  - name: LC_ALL
+    value: en_US.utf-8
+  - name: LANG
+    value: en_US.utf-8
   imagePullPolicy: Always
   name: database
   ports:
@@ -946,6 +958,10 @@ initContainers:
     value: /tmp
   - name: LDAPTLS_CACERT
     value: /etc/postgres/ldap/ca.crt
+  - name: LC_ALL
+    value: en_US.utf-8
+  - name: LANG
+    value: en_US.utf-8
   imagePullPolicy: Always
   name: postgres-startup
   resources: