Skip to content

Commit 1a385fe

Browse files
committed
Remove field text from EditMessageCaption and EditMessageReplyMarkup constructors #119
1 parent 2e57e92 commit 1a385fe

File tree

3 files changed

+46
-14
lines changed

3 files changed

+46
-14
lines changed

library/src/main/java/com/pengrad/telegrambot/request/EditMessageCaption.java

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,30 @@
1010
*/
1111
public class EditMessageCaption extends BaseRequest<EditMessageCaption, BaseResponse> {
1212

13-
public EditMessageCaption(Object chatId, int messageId, String text) {
13+
public EditMessageCaption(Object chatId, int messageId) {
1414
super(SendResponse.class);
15-
add("chat_id", chatId).add("message_id", messageId).add("text", text);
15+
add("chat_id", chatId).add("message_id", messageId);
1616
}
1717

18-
public EditMessageCaption(String inlineMessageId, String text) {
18+
public EditMessageCaption(String inlineMessageId) {
1919
super(BaseResponse.class);
20-
add("inline_message_id", inlineMessageId).add("text", text);
20+
add("inline_message_id", inlineMessageId);
21+
}
22+
23+
/**
24+
* @deprecated Use EditMessageCaption(Object chatId, int messageId)
25+
*/
26+
@Deprecated
27+
public EditMessageCaption(Object chatId, int messageId, String text) {
28+
this(chatId, messageId);
29+
}
30+
31+
/**
32+
* @deprecated Use EditMessageCaption(String inlineMessageId)
33+
*/
34+
@Deprecated
35+
public EditMessageCaption(String inlineMessageId, String text) {
36+
this(inlineMessageId);
2137
}
2238

2339
public EditMessageCaption caption(String caption) {

library/src/main/java/com/pengrad/telegrambot/request/EditMessageReplyMarkup.java

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,30 @@
1010
*/
1111
public class EditMessageReplyMarkup extends BaseRequest<EditMessageReplyMarkup, BaseResponse> {
1212

13-
public EditMessageReplyMarkup(Object chatId, int messageId, String text) {
13+
public EditMessageReplyMarkup(Object chatId, int messageId) {
1414
super(SendResponse.class);
15-
add("chat_id", chatId).add("message_id", messageId).add("text", text);
15+
add("chat_id", chatId).add("message_id", messageId);
1616
}
1717

18-
public EditMessageReplyMarkup(String inlineMessageId, String text) {
18+
public EditMessageReplyMarkup(String inlineMessageId) {
1919
super(BaseResponse.class);
20-
add("inline_message_id", inlineMessageId).add("text", text);
20+
add("inline_message_id", inlineMessageId);
21+
}
22+
23+
/**
24+
* @deprecated Use EditMessageReplyMarkup(Object chatId, int messageId)
25+
*/
26+
@Deprecated
27+
public EditMessageReplyMarkup(Object chatId, int messageId, String text) {
28+
this(chatId, messageId);
29+
}
30+
31+
/**
32+
* @deprecated Use EditMessageReplyMarkup(String inlineMessageId)
33+
*/
34+
@Deprecated
35+
public EditMessageReplyMarkup(String inlineMessageId, String text) {
36+
this(inlineMessageId);
2137
}
2238

2339
public EditMessageReplyMarkup replyMarkup(InlineKeyboardMarkup replyMarkup) {

library/src/test/java/com/pengrad/telegrambot/TelegramBotTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -179,15 +179,15 @@ public void editMessageText() {
179179
public void editMessageCaption() {
180180
String text = "Update " + System.currentTimeMillis();
181181

182-
BaseResponse response = bot.execute(new EditMessageCaption(chatId, 8124, text)
182+
BaseResponse response = bot.execute(new EditMessageCaption(chatId, 8124)
183183
.caption(text)
184184
.replyMarkup(new InlineKeyboardMarkup()));
185185
assertTrue(response.isOk());
186186

187-
response = bot.execute(new EditMessageCaption(channelName, 511, text).caption(text));
187+
response = bot.execute(new EditMessageCaption(channelName, 511).caption(text));
188188
assertTrue(response.isOk());
189189

190-
response = bot.execute(new EditMessageCaption("AgAAAPrwAQCj_Q4D2s-51_8jsuU", "").caption(text));
190+
response = bot.execute(new EditMessageCaption("AgAAAPrwAQCj_Q4D2s-51_8jsuU").caption(text));
191191
if (!response.isOk()) {
192192
assertEquals(400, response.errorCode());
193193
assertEquals("Bad Request: MESSAGE_ID_INVALID", response.description());
@@ -204,13 +204,13 @@ public void editMessageReplyMarkup() {
204204
InlineKeyboardMarkup gameKeyboard = new InlineKeyboardMarkup(new InlineKeyboardButton[]{
205205
new InlineKeyboardButton(text).callbackGame("test game")});
206206

207-
BaseResponse response = bot.execute(new EditMessageReplyMarkup(chatId, 8124, text).replyMarkup(keyboard));
207+
BaseResponse response = bot.execute(new EditMessageReplyMarkup(chatId, 8124).replyMarkup(keyboard));
208208
assertTrue(response.isOk());
209209

210-
response = bot.execute(new EditMessageReplyMarkup(channelName, 511, text).replyMarkup(keyboard));
210+
response = bot.execute(new EditMessageReplyMarkup(channelName, 511).replyMarkup(keyboard));
211211
assertTrue(response.isOk());
212212

213-
response = bot.execute(new EditMessageReplyMarkup("AgAAAPrwAQCj_Q4D2s-51_8jsuU", "").replyMarkup(gameKeyboard));
213+
response = bot.execute(new EditMessageReplyMarkup("AgAAAPrwAQCj_Q4D2s-51_8jsuU").replyMarkup(gameKeyboard));
214214
if (!response.isOk()) {
215215
assertEquals(400, response.errorCode());
216216
assertEquals("Bad Request: MESSAGE_ID_INVALID", response.description());

0 commit comments

Comments
 (0)