From fd1e309ca50ef8b3ae56a94c3395f08fce239578 Mon Sep 17 00:00:00 2001 From: Siva Rama Krishna Date: Wed, 30 Sep 2026 15:09:38 +0530 Subject: [PATCH] fix: upgrade pcore-pconnect-typedefs to version 5.1.0 --- CODE_OF_CONDUCT.md | 2 +- package-lock.json | 8 ++++---- package.json | 4 ++-- .../lib/_components/infra/navbar/navbar.component.ts | 3 +-- .../_components/infra/reference/reference.component.ts | 3 +-- .../advanced-search/advanced-search.component.ts | 1 - .../search-groups/search-groups.component.ts | 3 +-- .../template/app-shell/app-shell.component.ts | 3 +-- .../data-reference/data-reference.component.ts | 4 +--- .../template/data-reference/search-form/tabsData.ts | 1 - .../field-group-template.component.ts | 3 +-- .../simple-table-manual.component.ts | 1 - .../template/wss-nav-bar/wss-nav-bar.component.ts | 2 +- .../src/lib/_types/pcore-globals.d.ts | 10 ++++++++++ packages/angular-sdk-components/src/public-api.ts | 2 ++ 15 files changed, 26 insertions(+), 24 deletions(-) create mode 100644 packages/angular-sdk-components/src/lib/_types/pcore-globals.d.ts diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index 76a2723f7..b4b69ada2 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -60,7 +60,7 @@ representative at an online or offline event. Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at -john.arnold@pega.com. +opensource@pega.com and security@pega.com. All complaints will be reviewed and investigated promptly and fairly. All community leaders are obligated to respect the privacy and security of the diff --git a/package-lock.json b/package-lock.json index d38dee1c4..9ff8dd992 100644 --- a/package-lock.json +++ b/package-lock.json @@ -54,7 +54,7 @@ "@commitlint/config-conventional": "^21.2.3", "@eslint/js": "^10.0.1", "@pega/constellationjs": "~26.1.0", - "@pega/pcore-pconnect-typedefs": "4.1.0", + "@pega/pcore-pconnect-typedefs": "^5.1.1", "@playwright/test": "^1.63.0", "@types/jasmine": "~6.0.0", "@types/jasminewd2": "~2.0.13", @@ -6969,9 +6969,9 @@ } }, "node_modules/@pega/pcore-pconnect-typedefs": { - "version": "4.1.0", - "resolved": "https://registry.npmjs.org/@pega/pcore-pconnect-typedefs/-/pcore-pconnect-typedefs-4.1.0.tgz", - "integrity": "sha512-eMJ5M5H/oKnR22yH7pE5RAU3D/oLGNI0mJD2Dinqdyg9l2hUNVzifkRhy6kG58eyorcnnDAtmR11bY0FFNkezg==", + "version": "5.1.1", + "resolved": "https://registry.npmjs.org/@pega/pcore-pconnect-typedefs/-/pcore-pconnect-typedefs-5.1.1.tgz", + "integrity": "sha512-Xbqvh5quUN1btK1UHJpoSt0fOM/qMQtQHt47WKRqU0YfJ7OSyVbJsu2h3OZKV5fQIrN2FE/fdNDw0TY2vHXcZA==", "dev": true, "license": "See LICENSE in LICENSE file" }, diff --git a/package.json b/package.json index 7dbdbce1a..d39fbf7a2 100644 --- a/package.json +++ b/package.json @@ -104,8 +104,9 @@ "@angular/language-service": "^21.2.4", "@commitlint/cli": "^21.2.3", "@commitlint/config-conventional": "^21.2.3", + "@eslint/js": "^10.0.1", "@pega/constellationjs": "~26.1.0", - "@pega/pcore-pconnect-typedefs": "4.1.0", + "@pega/pcore-pconnect-typedefs": "^5.1.1", "@playwright/test": "^1.63.0", "@types/jasmine": "~6.0.0", "@types/jasminewd2": "~2.0.13", @@ -113,7 +114,6 @@ "brotli": "^1.3.3", "compressing": "^2.1.3", "copy-webpack-plugin": "^14.0.0", - "@eslint/js": "^10.0.1", "eslint": "^10.11.0", "eslint-plugin-jest": "^29.16.6", "eslint-plugin-sonarjs": "^4.2.2", diff --git a/packages/angular-sdk-components/src/lib/_components/infra/navbar/navbar.component.ts b/packages/angular-sdk-components/src/lib/_components/infra/navbar/navbar.component.ts index 217e2e832..219e4da39 100644 --- a/packages/angular-sdk-components/src/lib/_components/infra/navbar/navbar.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/infra/navbar/navbar.component.ts @@ -34,7 +34,7 @@ export class NavbarComponent implements OnInit, OnDestroy { bShowCaseTypes$ = false; portalApp$: string | undefined = ''; - portalLogoImage$: string; + portalLogoImage$: string | Blob | null; showAppName$?: boolean = false; portalOperator$: string | undefined; @@ -110,7 +110,6 @@ export class NavbarComponent implements OnInit, OnDestroy { // making a copy, so can add info this.navPages$ = JSON.parse(JSON.stringify(this.pages$)); - // @ts-ignore const localeReference = PCore.getLocaleUtils().getPortalLocaleReference() || this.pConn$.getValue('.pyLocaleReference'); this.navPages$.forEach(page => { const destinationObject: any = {}; diff --git a/packages/angular-sdk-components/src/lib/_components/infra/reference/reference.component.ts b/packages/angular-sdk-components/src/lib/_components/infra/reference/reference.component.ts index e711ef04e..d70957a64 100644 --- a/packages/angular-sdk-components/src/lib/_components/infra/reference/reference.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/infra/reference/reference.component.ts @@ -88,8 +88,7 @@ export class ReferenceComponent implements OnInit, OnDestroy, OnChanges { } }; - // @ts-expect-error - createComponent expects string but null is passed for unused parameters (matches React SDK pattern) - const viewComponent: any = pConnect.createComponent(viewObject, null, null, { + const viewComponent: any = pConnect.createComponent(viewObject, '', 0, { pageReference: context && context.startsWith('@CLASS') ? '' : context }); diff --git a/packages/angular-sdk-components/src/lib/_components/template/advanced-search/advanced-search.component.ts b/packages/angular-sdk-components/src/lib/_components/template/advanced-search/advanced-search.component.ts index 8d201661e..1cc27f412 100644 --- a/packages/angular-sdk-components/src/lib/_components/template/advanced-search/advanced-search.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/template/advanced-search/advanced-search.component.ts @@ -71,7 +71,6 @@ export class AdvancedSearchComponent implements OnInit, OnChanges { const [firstChildMeta] = rawViewMetadata.children; const localizedVal = PCore.getLocaleUtils().getLocaleValue; - // @ts-ignore const cache = PCore.getNavigationUtils().getComponentCache(searchSelectCacheKey) ?? {}; this.editableFieldComp = firstChildPConnect().createComponent({ diff --git a/packages/angular-sdk-components/src/lib/_components/template/advanced-search/search-groups/search-groups.component.ts b/packages/angular-sdk-components/src/lib/_components/template/advanced-search/search-groups/search-groups.component.ts index bd3e4c116..fa52b43b2 100755 --- a/packages/angular-sdk-components/src/lib/_components/template/advanced-search/search-groups/search-groups.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/template/advanced-search/search-groups/search-groups.component.ts @@ -210,8 +210,7 @@ export class SearchGroupsComponent implements OnInit, OnDestroy, OnChanges { isValidInput(formValues) ) { if (this.isValidatorField) { - // @ts-ignore - PCore.getMessageManager().clearContextMessages({ context: transientItemID }); + PCore.getMessageManager().clearContextMessages({ context: this.transientItemID }); } this.previousFormValues = formValues; diff --git a/packages/angular-sdk-components/src/lib/_components/template/app-shell/app-shell.component.ts b/packages/angular-sdk-components/src/lib/_components/template/app-shell/app-shell.component.ts index 498729fd0..274366c5c 100644 --- a/packages/angular-sdk-components/src/lib/_components/template/app-shell/app-shell.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/template/app-shell/app-shell.component.ts @@ -52,7 +52,7 @@ export class AppShellComponent implements OnInit, OnDestroy { bOkDisplayError = false; portalTemplate: string; links: any = []; - imageURL: string | Blob; + imageURL: string | Blob | null; localizedVal = PCore.getLocaleUtils().getLocaleValue; constructor( @@ -89,7 +89,6 @@ export class AppShellComponent implements OnInit, OnDestroy { PCore.getEnvironmentInfo().setEnvironmentInfo({ ...PCore.getEnvironmentInfo().environmentInfoObject, pyPortalTemplate: 'wss' } as any); } - // @ts-ignore - Property 'pyCaseTypesAvailableToCreateDP' does not exist on type pxApplication const caseTypesAvailableToCreateDP = PCore.getEnvironmentInfo().environmentInfoObject?.pxApplication?.pyCaseTypesAvailableToCreateDP; if (caseTypesAvailableToCreateDP) { const portalID = this.pConn$.getValue('.pyOwner'); diff --git a/packages/angular-sdk-components/src/lib/_components/template/data-reference/data-reference.component.ts b/packages/angular-sdk-components/src/lib/_components/template/data-reference/data-reference.component.ts index 4e3c25cce..27ec02c38 100644 --- a/packages/angular-sdk-components/src/lib/_components/template/data-reference/data-reference.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/template/data-reference/data-reference.component.ts @@ -152,8 +152,7 @@ export class DataReferenceComponent implements OnInit, OnDestroy { this.isDisplayModeEnabled = ['DISPLAY_ONLY', 'STACKED_LARGE_VAL'].includes(displayMode); this.refFieldMetadata = this.pConn$.getFieldMetadata(this.rawViewMetadata?.config?.authorContext); this.pyID = getMappedKey('pyID'); - // @ts-ignore - const { allowImplicitRefresh } = PCore.getFieldDefaultUtils().fieldDefaults?.DataReference || {}; + const { allowImplicitRefresh } = PCore.getFieldDefaultUtils().fieldDefaults?.['DataReference'] || {}; this.allowImplicitRefresh = allowImplicitRefresh; this.isDDSourceDeferred = @@ -398,7 +397,6 @@ export class DataReferenceComponent implements OnInit, OnDestroy { if (['Dropdown', 'Checkbox', 'RadioButtons'].includes(type) && !config.deferDatasource && config.datasource) { const isCardVariant = config.variant === 'card'; const hasParameters = this.rawViewMetadata.config?.parameters; - // @ts-ignore const isDeferDataPageCallEnabled = isCardVariant && hasParameters && !this.firstChildPConnect()?.getSharedDataPageForReferenceList(); const useDropDownDataSource = (isCardVariant && (this.dropDownDataSource || isDeferDataPageCallEnabled)) || (!isCardVariant && hasParameters); diff --git a/packages/angular-sdk-components/src/lib/_components/template/data-reference/search-form/tabsData.ts b/packages/angular-sdk-components/src/lib/_components/template/data-reference/search-form/tabsData.ts index e5c67df61..652006932 100644 --- a/packages/angular-sdk-components/src/lib/_components/template/data-reference/search-form/tabsData.ts +++ b/packages/angular-sdk-components/src/lib/_components/template/data-reference/search-form/tabsData.ts @@ -127,7 +127,6 @@ export function getData(deferLoadedTabs, tabCountSources, currentTabId, data) { }); } else if (calculatedFieldsWithoutValue.length) { PCore.getViewRuleApi() - // @ts-ignore .getCalculatedFields( pConn.getCaseInfo().getKey(), pConn.getCurrentView(), diff --git a/packages/angular-sdk-components/src/lib/_components/template/field-group-template/field-group-template.component.ts b/packages/angular-sdk-components/src/lib/_components/template/field-group-template/field-group-template.component.ts index c96c0f42a..da21c1c7d 100644 --- a/packages/angular-sdk-components/src/lib/_components/template/field-group-template/field-group-template.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/template/field-group-template/field-group-template.component.ts @@ -132,8 +132,7 @@ export class FieldGroupTemplateComponent implements OnInit, OnDestroy, OnChanges } if (this.referenceListLength() != referenceList?.length) { - // @ts-ignore - Expected 3 arguments, but got 1 - this.pConn$.getListActions().initDefaultPageInstructions(resolvedList); + this.pConn$.getListActions().initDefaultPageInstructions(resolvedList, []); this.children = referenceList?.map((item, index) => { return { diff --git a/packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/simple-table-manual.component.ts b/packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/simple-table-manual.component.ts index 7267d2159..888a388e0 100755 --- a/packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/simple-table-manual.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/simple-table-manual.component.ts @@ -464,7 +464,6 @@ export class SimpleTableManualComponent implements OnInit, OnDestroy { if (typeof allowRowDelete === 'string' && allowRowDelete.startsWith('@E ')) { try { const expression = allowRowDelete.replace('@E ', ''); - // @ts-expect-error - options param is optional per corejs docs return PCore.getExpressionEngine().evaluate(expression, row); } catch { return true; diff --git a/packages/angular-sdk-components/src/lib/_components/template/wss-nav-bar/wss-nav-bar.component.ts b/packages/angular-sdk-components/src/lib/_components/template/wss-nav-bar/wss-nav-bar.component.ts index 03bfeb3e6..e6db648b5 100644 --- a/packages/angular-sdk-components/src/lib/_components/template/wss-nav-bar/wss-nav-bar.component.ts +++ b/packages/angular-sdk-components/src/lib/_components/template/wss-nav-bar/wss-nav-bar.component.ts @@ -27,7 +27,7 @@ export class WssNavBarComponent implements OnInit, OnDestroy { @Input() pages$: any[]; @Input() caseTypes$: any[]; @Input() homePage: any; - @Input() portalLogoImage$: string; + @Input() portalLogoImage$: string | Blob | null; // For interaction with AngularPConnect angularPConnectData: AngularPConnectData = {}; diff --git a/packages/angular-sdk-components/src/lib/_types/pcore-globals.d.ts b/packages/angular-sdk-components/src/lib/_types/pcore-globals.d.ts new file mode 100644 index 000000000..ebeb3bff2 --- /dev/null +++ b/packages/angular-sdk-components/src/lib/_types/pcore-globals.d.ts @@ -0,0 +1,10 @@ +import type PCoreInstance from '@pega/pcore-pconnect-typedefs'; +import type { C11nEnv } from '@pega/pcore-pconnect-typedefs/interpreter/c11n-env'; + +declare global { + var PCore: PCoreInstance; + var PConnect: C11nEnv; + function getPConnect(): C11nEnv; +} + +export {}; diff --git a/packages/angular-sdk-components/src/public-api.ts b/packages/angular-sdk-components/src/public-api.ts index 377719417..62f6b9983 100644 --- a/packages/angular-sdk-components/src/public-api.ts +++ b/packages/angular-sdk-components/src/public-api.ts @@ -2,6 +2,8 @@ * Public API Surface of angular-sdk-components */ +import type {} from './lib/_types/pcore-globals'; + export * from './sdk-local-component-map'; export * from './lib/_bridge/component-mapper/component-mapper.component';