fix(context-menu): render menu inline and use viewport coordinates#314
Merged
Conversation
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lhein
force-pushed
the
120_fixCutContextMenus
branch
from
308d78c to
043b4c9
Compare
Contributor
|
thanks @jeff-phillips-18 @nicolethoen 🙏 |
nicolethoen
approved these changes
May 12, 2026
|
🎉 This PR is included in version 6.5.0-prerelease.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #120
Description
This updates the topology context menu so it can flip correctly near the viewport edge.
The main change is that
ContextMenunow renders a PatternFlyMenudirectly inside the topology popper instead of rendering a nestedDropdownwith its own popper. This allows the outer topology popper to measure the actual menu height and position it correctly.This PR also switches point-based context menu references in
withContextMenufrompageX/pageYtoclientX/clientY, which is consistent with viewport-based popper positioning.Root cause
The visible context menu was effectively wrapped in a second popper layer. Because of that, the outer topology popper did not have reliable dimensions for the real menu content, so bottom-edge flipping did not work as expected.
Type of change
Screen shots / Gifs for design review
Before:
After: