refactor(nestedpatterns): trigger warning message only after checking for whether it's actually a pattern file (#1311)

* refactor(nestedpatterns): show nested pattern warning only for pattern files #1309

* refactor(nestedpatterns): show nested pattern warning only for pattern files #1309

…iles by moving the pattern test before the warning message #1309

Author: mfranzke

packages/core/src/lib/loadPattern.js

@@ -20,6 +20,19 @@ let fs = require('fs-extra'); //eslint-disable-line prefer-const
 // loads a pattern from disk, creates a Pattern object from it and
 // all its associated files, and records it in patternlab.patterns[]
 module.exports = function(relPath, patternlab) {
+  const fileObject = path.parse(relPath);
+
+  //extract some information
+  const filename = fileObject.base;
+  const ext = fileObject.ext;
+  const patternsPath = patternlab.config.paths.source.patterns;
+
+  // skip non-pattern files
+  if (!patternEngines.isPatternFile(filename, patternlab)) {
+    return null;
+  }
+
+  // Determine patterns nested too deep and show a warning
   const relativeDepth = (relPath.match(/\w(?=\\)|\w(?=\/)/g) || []).length;
   if (relativeDepth > 3) {
     logger.warning('');
@@ -51,18 +64,6 @@ module.exports = function(relPath, patternlab) {
     logger.warning('');
   }
 
-  const fileObject = path.parse(relPath);
-
-  //extract some information
-  const filename = fileObject.base;
-  const ext = fileObject.ext;
-  const patternsPath = patternlab.config.paths.source.patterns;
-
-  // skip non-pattern files
-  if (!patternEngines.isPatternFile(filename, patternlab)) {
-    return null;
-  }
-
   //make a new Pattern Object
   const currentPattern = new Pattern(relPath, null, patternlab);