Add pgdump-args option to save command

Author: trnubo

commands/common.sh

@@ -86,7 +86,7 @@ parse_options() {
 
     # Options and long options
     local options="h:p:U:d:W:"
-    local longopts="host:,port:,username:,dbname:,password:,password-file:,no-create-database,no-revoke-public-create,drop-database,format:,compression:,umask:,skip-globals,skip-database:,skip-analyze,full-count,aws-args:"
+    local longopts="host:,port:,username:,dbname:,password:,password-file:,no-create-database,no-revoke-public-create,drop-database,format:,compression:,umask:,skip-globals,skip-database:,skip-analyze,full-count,aws-args:,pgdump-args:"
     local parsed
 
     # Parse with getopt (not getopts)
@@ -162,6 +162,10 @@ parse_options() {
           IFS=$' \n\t' read -r -a aws_args <<<"${2}"
           shift 2
           ;;
+        --pgdump-args)
+          IFS=$' \n\t' read -r -a pgdump_args <<<"${2}"
+          shift 2
+          ;;
         --)
           shift
           break

commands/save

@@ -27,7 +27,7 @@ usage() {
     global_options
     echoerr ""
     echoerr "Options:"
-    echoerr "    --pgdump-args    NOT IMPLEMENTED"
+    echoerr "    --pgdump-args    OPTIONS"
     echoerr "    --aws-args    OPTIONS"
     echoerr "    --format    plain|custom"
     echoerr "    --compression    gzip|lz4|bz2|none"
@@ -53,6 +53,9 @@ unset "args[-1]"
 umask "${umask:-0077}"
 
 date="$(date --utc "+${date_format:-%Y%m%d%H%M%S}")"
+# Undocumented feature to allow overriding the date.
+# Useful when using offloaded backup so the actual snapshot date can be used.
+date="${OVERRIDE_DATE:-${date}}"
 
 case "${dest}" in
     gs://*)
@@ -77,7 +80,7 @@ case "${dest}" in
         ;;
     esac
 
-cmd_args=()
+cmd_args=( "${pgdump_args[@]}" )
 file_ext=()
 file_path=( "${dest}" "${date}" )
 

tests/save.bats

@@ -32,7 +32,7 @@ teardown_file() {
 		-e DATABASE_USERNAME=postgres \
 		-e DATABASE_PASSWORD=password \
 		-v "${working_volume}:/db-dumps" \
-		"${TOOLBOX_IMAGE}" save --umask 022 /db-dumps
+		"${TOOLBOX_IMAGE}" save --umask 022 --pgdump-args "--compress 0" --format custom /db-dumps
 	diag "${output}"
 	[[ "${status}" -eq 0 ]]
 }