BUG: pytables with non-nano timedelta64 #63239
Merged
+39
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
IO HDF5
jorisvandenbossche
approved these changes
Dec 1, 2025
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Looks good!
The consequence is that a file written with 3.0 (with a timedelta column) won't be readable by older pandas versions?
(although right now if you write non-nanos, they just come back as wrong values)
Can you add a whatsnew note as you had in #55622?
pandas/core/computation/pytables.py
Outdated
Comment on lines
233
to
234
| # TODO: other timedelta64 units? 2025-11-30 only | ||
| # test_append_with_timedelta gets here |
Member
There was a problem hiding this comment.
Could parametrize test_append_with_timedelta for the different units? (or is there already other coverage?)
Member
Author
Correct.
Done. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.Surfaced by #63196, which currently xfails test_preserve_timedeltaindex_type. This implements a fix.