TST: Add regression test for DataFrame.where with nullable dtype (#49052) #63222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 1, 2025
| def test_where_other_nullable_dtype(): | ||
| # GH#49052 DataFrame.where should return nullable dtype when | ||
| # other is a Series with nullable dtype, matching Series.where behavior | ||
| df = Series([1, 2, 3], dtype="int64").to_frame() |
Member
There was a problem hiding this comment.
Suggested change
| df = Series([1, 2, 3], dtype="int64").to_frame() | |
| df = DataFrame([1, 2, 3], dtype="int64") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.This PR adds a regression test for #49052.
The bug was that
DataFrame.wherewould returnobjectdtype whenotherwas aSerieswith nullable dtype (e.g.,Int64), whileSeries.wherecorrectly returned the nullable dtype. This has been fixed on main and this test ensures the fix is not regressed.