ENH: Set __module__ on StringDtype #60261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espoirMur
changed the title
espoirMur
changed the title
simonjayhawkins
added
Output-Formatting
simonjayhawkins
requested changes
Nov 9, 2024
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
thanks @espoirMur
a couple of changes needed
pandas/core/arrays/string_.py
Outdated
| # error: Definition of "_concat_same_type" in base class "NDArrayBacked" is | ||
| # incompatible with definition in base class "ExtensionArray" | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
please revert these additions
pandas/core/arrays/string_.py
Outdated
| return new_string_array | ||
|
|
||
|
|
||
| @set_module("pandas") |
Member
There was a problem hiding this comment.
AttributeError: module 'pandas' has no attribute 'BaseStringArray'
jorisvandenbossche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__module__on top-level public objects #55178doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.