Removed GNU strdup extension from JSON (#49780)

* removed GNU extension from JSON

* Revert "removed GNU extension from JSON"

This reverts commit cd6b630.

* try again

* Better setlocale error

* Copied string

* make cpplint happy

* typo fix

* memcpy instead of snprintf

* try catchsegv

* single doc build

* Revert "single doc build"

This reverts commit c9f5225.

* Revert "try catchsegv"

This reverts commit a6199a8.

* Fixed wrong free

Author: WillAyd

pandas/_libs/src/headers/portable.h

@@ -1,16 +1,10 @@
 #ifndef _PANDAS_PORTABLE_H_
 #define _PANDAS_PORTABLE_H_
 
-// To get `strdup` from strings.h
-#ifndef _XOPEN_SOURCE
-#define _XOPEN_SOURCE 600
-#endif
-
 #include <string.h>
 
 #if defined(_MSC_VER)
 #define strcasecmp( s1, s2 ) _stricmp( s1, s2 )
-#define strdup _strdup
 #endif
 
 // GH-23516 - works around locale perf issues

pandas/_libs/src/ujson/lib/ultrajsondec.c

@@ -1174,15 +1174,21 @@ JSOBJ JSON_DecodeObject(JSONObjectDecoder *dec, const char *buffer,
     ds.dec = dec;
 
     locale = setlocale(LC_NUMERIC, NULL);
+    if (!locale) {
+        return SetError(&ds, -1, "setlocale call failed");
+    }
+
     if (strcmp(locale, "C")) {
-        locale = strdup(locale);
-        if (!locale) {
-            return SetError(&ds, -1, "Could not reserve memory block");
+        size_t len = strlen(locale) + 1;
+        char *saved_locale = malloc(len);
+        if (saved_locale == NULL) {
+          return SetError(&ds, -1, "Could not reserve memory block");
         }
+        memcpy(saved_locale, locale, len);
         setlocale(LC_NUMERIC, "C");
         ret = decode_any(&ds);
-        setlocale(LC_NUMERIC, locale);
-        free(locale);
+        setlocale(LC_NUMERIC, saved_locale);
+        free(saved_locale);
     } else {
         ret = decode_any(&ds);
     }

pandas/_libs/src/ujson/lib/ultrajsonenc.c

@@ -1176,16 +1176,23 @@ char *JSON_EncodeObject(JSOBJ obj, JSONObjectEncoder *enc, char *_buffer,
     enc->offset = enc->start;
 
     locale = setlocale(LC_NUMERIC, NULL);
+    if (!locale) {
+        SetError(NULL, enc, "setlocale call failed");
+        return NULL;
+    }
+
     if (strcmp(locale, "C")) {
-        locale = strdup(locale);
-        if (!locale) {
-            SetError(NULL, enc, "Could not reserve memory block");
-            return NULL;
+        size_t len = strlen(locale) + 1;
+        char *saved_locale = malloc(len);
+        if (saved_locale == NULL) {
+          SetError(NULL, enc, "Could not reserve memory block");
+          return NULL;
         }
+        memcpy(saved_locale, locale, len);
         setlocale(LC_NUMERIC, "C");
         encode(obj, enc, NULL, 0);
-        setlocale(LC_NUMERIC, locale);
-        free(locale);
+        setlocale(LC_NUMERIC, saved_locale);
+        free(saved_locale);
     } else {
         encode(obj, enc, NULL, 0);
     }

setup.py

@@ -649,7 +649,7 @@ def srcpath(name=None, suffix=".pyx", subdir="src"):
         "pandas/_libs/src/datetime",
         numpy.get_include(),
     ],
-    extra_compile_args=(["-D_GNU_SOURCE"] + extra_compile_args),
+    extra_compile_args=(extra_compile_args),
     extra_link_args=extra_link_args,
     define_macros=macros,
 )