add comments + update tests

Author: jorisvandenbossche

pandas/core/indexes/base.py

@@ -5023,6 +5023,7 @@ def array(self) -> ExtensionArray:
             from pandas.core.arrays.numpy_ import NumpyExtensionArray
 
             array = NumpyExtensionArray(array)
+        # TODO decide on read-only https://github.com/pandas-dev/pandas/issues/63099
         # array = array.view()
         # array._readonly = True
         return array

pandas/core/internals/blocks.py

@@ -2387,6 +2387,7 @@ def external_values(values: ArrayLike) -> ArrayLike:
         values.flags.writeable = False
     else:
         # ExtensionArrays
+        # TODO decide on read-only https://github.com/pandas-dev/pandas/issues/63099
         # values = values.view()
         # values._readonly = True
         pass

pandas/core/series.py

@@ -821,6 +821,7 @@ def _references(self) -> BlockValuesRefs:
     @property
     def array(self) -> ExtensionArray:
         arr = self._mgr.array_values()
+        # TODO decide on read-only https://github.com/pandas-dev/pandas/issues/63099
         # arr = arr.view()
         # arr._readonly = True
         return arr

pandas/tests/copy_view/test_array.py

@@ -19,18 +19,27 @@
     "method",
     [
         lambda ser: ser.values,
-        # lambda ser: np.asarray(ser.array),
+        lambda ser: np.asarray(ser.array),
         lambda ser: np.asarray(ser),
         lambda ser: np.array(ser, copy=False),
     ],
-    ids=["values", "np.asarray", "np.array"],
+    ids=["values", "array", "np.asarray", "np.array"],
 )
-def test_series_values(method):
+def test_series_values(request, method):
     ser = Series([1, 2, 3], name="name")
     ser_orig = ser.copy()
 
     arr = method(ser)
 
+    if request.node.callspec.id == "array":
+        # https://github.com/pandas-dev/pandas/issues/63099
+        # .array for now does not return a read-only view
+        assert arr.flags.writeable is True
+        # updating the array updates the series
+        arr[0] = 0
+        assert ser.iloc[0] == 0
+        return
+
     # .values still gives a view but is read-only
     assert np.shares_memory(arr, get_array(ser, "name"))
     assert arr.flags.writeable is False
@@ -109,20 +118,42 @@ def test_series_to_numpy():
 @pytest.mark.parametrize(
     "method",
     [
-        # lambda ser: np.asarray(ser.array),
+        lambda ser: np.asarray(ser.values),
+        lambda ser: np.asarray(ser.array),
         lambda ser: np.asarray(ser),
         lambda ser: np.asarray(ser, dtype="int64"),
         lambda ser: np.array(ser, copy=False),
     ],
-    ids=["np.asarray", "np.asarray-dtype", "np.array"],
+    ids=["values", "array", "np.asarray", "np.asarray-dtype", "np.array"],
 )
-def test_series_values_ea_dtypes(method):
+def test_series_values_ea_dtypes(request, method):
     ser = Series([1, 2, 3], dtype="Int64")
+    ser_orig = ser.copy()
+
     arr = method(ser)
 
+    if request.node.callspec.id in ("values", "array"):
+        # https://github.com/pandas-dev/pandas/issues/63099
+        # .array/values for now does not return a read-only view
+        assert arr.flags.writeable is True
+        # updating the array updates the series
+        arr[0] = 0
+        assert ser.iloc[0] == 0
+        return
+
+    # conversion to ndarray gives a view but is read-only
     assert np.shares_memory(arr, get_array(ser))
     assert arr.flags.writeable is False
 
+    # mutating series through arr therefore doesn't work
+    with pytest.raises(ValueError, match="read-only"):
+        arr[0] = 0
+    tm.assert_series_equal(ser, ser_orig)
+
+    # mutating the series itself still works
+    ser.iloc[0] = 0
+    assert ser.values[0] == 0
+
 
 @pytest.mark.parametrize(
     "method",