STYLE: Enable unnecessary list index lookup (#49911)

* Enable Pylint unnecessary-list-index-lookup warning

Fix one instance of the issue and add messages to suppress several others in test modules

* Update list of intentionally disabled pylint checks

* Move pylint suppression comments

Author: uzzell

pandas/io/pytables.py

@@ -4368,7 +4368,7 @@ def write_data(self, chunksize: int | None, dropna: bool = False) -> None:
         bvalues = []
         for i, v in enumerate(values):
             new_shape = (nrows,) + self.dtype[names[nindexes + i]].shape
-            bvalues.append(values[i].reshape(new_shape))
+            bvalues.append(v.reshape(new_shape))
 
         # write the chunks
         if chunksize is None:

pandas/tests/indexes/datetimes/test_datetime.py

@@ -98,7 +98,7 @@ def test_iteration_preserves_tz(self):
 
         for i, ts in enumerate(index):
             result = ts
-            expected = index[i]
+            expected = index[i]  # pylint: disable=unnecessary-list-index-lookup
             assert result == expected
 
         index = date_range(
@@ -107,7 +107,7 @@ def test_iteration_preserves_tz(self):
 
         for i, ts in enumerate(index):
             result = ts
-            expected = index[i]
+            expected = index[i]  # pylint: disable=unnecessary-list-index-lookup
             assert result._repr_base == expected._repr_base
             assert result == expected
 
@@ -117,7 +117,7 @@ def test_iteration_preserves_tz(self):
         )
         for i, ts in enumerate(index):
             result = ts
-            expected = index[i]
+            expected = index[i]  # pylint: disable=unnecessary-list-index-lookup
             assert result._repr_base == expected._repr_base
             assert result == expected
 

pandas/tests/indexes/datetimes/test_timezones.py

@@ -1211,7 +1211,7 @@ def test_iteration_preserves_nanoseconds(self, tz):
             ["2018-02-08 15:00:00.168456358", "2018-02-08 15:00:00.168456359"], tz=tz
         )
         for i, ts in enumerate(index):
-            assert ts == index[i]
+            assert ts == index[i]  # pylint: disable=unnecessary-list-index-lookup
 
 
 def test_tz_localize_invalidates_freq():

pandas/tests/series/test_iteration.py

@@ -4,10 +4,12 @@ def test_keys(self, datetime_series):
 
     def test_iter_datetimes(self, datetime_series):
         for i, val in enumerate(datetime_series):
+            # pylint: disable-next=unnecessary-list-index-lookup
             assert val == datetime_series[i]
 
     def test_iter_strings(self, string_series):
         for i, val in enumerate(string_series):
+            # pylint: disable-next=unnecessary-list-index-lookup
             assert val == string_series[i]
 
     def test_iteritems_datetimes(self, datetime_series):

pyproject.toml

@@ -59,6 +59,7 @@ exclude = '''
 max-line-length = 88
 disable = [
  # intentionally turned off
+  "broad-except",
   "c-extension-no-member",
   "comparison-with-itself",
   "import-error",
@@ -72,6 +73,7 @@ disable = [
   "no-member",
   "no-name-in-module",
   "not-an-iterable",
+  "overridden-final-method",
   "pointless-statement",
   "redundant-keyword-arg",
   "singleton-comparison",
@@ -95,7 +97,6 @@ disable = [
   "use-implicit-booleaness-not-comparison",
   "use-implicit-booleaness-not-len",
   "wrong-import-order",
-  "wrong-import-order",
   "wrong-import-position",
 
  # misc
@@ -122,15 +123,13 @@ disable = [
   "inconsistent-return-statements",
   "redefined-argument-from-local",
   "too-few-public-methods",
-  "unnecessary-list-index-lookup",
 
   # pylint type "W": warning, for python specific problems
   "abstract-method",
   "arguments-differ",
   "arguments-out-of-order",
   "arguments-renamed",
   "attribute-defined-outside-init",
-  "broad-except",
   "comparison-with-callable",
   "dangerous-default-value",
   "deprecated-module",
@@ -140,7 +139,6 @@ disable = [
   "global-statement",
   "invalid-overridden-method",
   "keyword-arg-before-vararg",
-  "overridden-final-method",
   "pointless-string-statement",
   "possibly-unused-variable",
   "protected-access",