use np_ndarray_intp, np_ndarray_int64, np_ndarray_float aliases more #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
use-ndarray-aliases
branch
2 times, most recently
from
9f463ed to
fbb8851
Compare
MarcoGorelli
force-pushed
the
use-ndarray-aliases
branch
from
fbb8851 to
92cc699
Compare
cmp0xff
approved these changes
Nov 30, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Thank you @MarcoGorelli ! In the tests we now have a mixture:
check(assert_type(b + left, "npt.NDArray[np.bool_]"), pd.Index, np.complexfloating)
check(assert_type(i + left, np_ndarray_int64), pd.Index, np.complexfloating)Could you create an Issue and make the practice consistent?
Member
Author
|
yup, will address the rest tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1425 (review)
assert_type()to assert the type of any return value)AGENTS.md.