FIX: #1508 numpy 1darrays in tests #1512
Merged
+64
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
changed the title
cmp0xff
force-pushed
the
bugfix/numpy_arrays_in_tests
branch
from
10a59cd to
034f12b
Compare
loicdiridollou
approved these changes
Nov 30, 2025
Member
loicdiridollou
left a comment
loicdiridollou
left a comment
There was a problem hiding this comment.
Looks good, thanks @cmp0xff !!
cmp0xff
added a commit
that referenced
this pull request
Dec 1, 2025
* GH1432 Partial resolution * GH1432 PR Feedback * type Index methods: putmask, asof, asof_locs, sort_values, get_indexer_non_unique, get_indexer_for, map, get_slice_bound (#1505) * type Index methods: putmask, asof, asof_locs, sort_values, get_indexer_non_unique, get_indexer_for, map, get_slice_bound * remove redundant `IntervalIndexer.get_indexer_non_unique` * slice_locs can return either `np.integer` or `int` * fix slice_locs test * Apply suggestions from code review Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com> * np.integer -> np.intp * test more mask types for `putmask` * Apply suggestions from code review Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com> * test asof with str --------- Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com> * GH1432 PR Feedback * FIX: #1508 numpy 1darrays in tests (#1512) fix: #1508 numpy arrays in tests * GH1484 Upgrade ty (#1509) * GH1484 Upgrade ty * GH1484 Fix formatting * GH1484 Update PR * GH1432 Partial resolution * GH1432 PR Feedback * Update tests/test_timefuncs.py Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com> --------- Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com> Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1508 I realised that
np_1darray_*intestshas been incorrect. The fixes seem to be independent of #1503, hence I am separating them here.