GH1432 PR Feedback

Author: loicdiridollou

tests/test_timefuncs.py

@@ -94,16 +94,21 @@ def test_types_arithmetic() -> None:
     ts = pd.to_datetime("2021-03-01")
     ts2 = pd.to_datetime("2021-01-01")
     ts_np = np.datetime64("2021-01-01")
+    ts_np_time = np.datetime64("2021-01-01 08:00:05")
     delta = pd.to_timedelta("1 day")
 
     check(assert_type(ts - ts2, pd.Timedelta), pd.Timedelta)
     check(assert_type(ts - ts_np, pd.Timedelta), pd.Timedelta)
-    # TODO: pandas-dev/pandas-stubs#1432 mypy sees datetime.timedelta but pyright is correct
-    # check(assert_type(ts_np - ts, pd.Timedelta), pd.Timedelta)
+    check(assert_type(ts - ts_np_time, pd.Timedelta), pd.Timedelta)
     check(assert_type(ts + delta, pd.Timestamp), pd.Timestamp)
     check(assert_type(ts - delta, pd.Timestamp), pd.Timestamp)
     check(assert_type(ts - dt.datetime(2021, 1, 3), pd.Timedelta), pd.Timedelta)
 
+    if TYPE_CHECKING_INVALID_USAGE:
+        # TODO: pandas-dev/pandas-stubs#1432 mypy sees datetime.timedelta but pyright is correct
+        assert_type(ts_np - ts, pd.Timedelta)  # type: ignore[assert-type]
+        assert_type(ts_np_time - ts, pd.Timedelta)  # type: ignore[assert-type]
+
 
 def test_types_comparison() -> None:
     ts = pd.to_datetime("2021-03-01")