From ce323e674e827564543b3c8c42d4fb53ab0c8e26 Mon Sep 17 00:00:00 2001 From: Daniel Date: Sat, 21 Nov 2026 00:12:47 +0100 Subject: [PATCH 1/3] Formalized Aperture VertexParameters --- src/pals/parameters/ApertureParameters.py | 16 ++++++++++++++++ tests/test_serialization.py | 5 +++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/pals/parameters/ApertureParameters.py b/src/pals/parameters/ApertureParameters.py index 3db501d..922429e 100644 --- a/src/pals/parameters/ApertureParameters.py +++ b/src/pals/parameters/ApertureParameters.py @@ -1,8 +1,23 @@ +import builtins + from annotated_types import Ge from typing import Annotated, Literal from pydantic import BaseModel, Field, field_validator +class Vertex(BaseModel): + point: tuple[float, float] + radius: float | tuple[float, float] | None = None + convex: bool = True + tilt: float = 0 + + +class Vertices(BaseModel): + center: tuple[float, float] = Field(default=(0, 0)) + absolute_vertices: bool = False + list: builtins.list[Vertex] = Field(default_factory=builtins.list) + + class ApertureParameters(BaseModel): """Aperture parameters""" @@ -26,3 +41,4 @@ def validate_limits(cls, v): thickness: Annotated[float, Ge(0.0)] = 0.0 aperture_shifts_with_body: bool = False aperture_active: bool = True + vertices: Vertices | None = None diff --git a/tests/test_serialization.py b/tests/test_serialization.py index d079d2c..e4e1741 100644 --- a/tests/test_serialization.py +++ b/tests/test_serialization.py @@ -1,6 +1,7 @@ import pytest import pals +from pals.parameters.ApertureParameters import Vertex, Vertices def test_yaml(tmp_path): @@ -147,7 +148,7 @@ def test_comprehensive_lattice(tmp_path): name="sextupole1", length=0.2, MagneticMultipoleP=pals.MagneticMultipoleParameters(Bn2=1.0), - ApertureP=pals.ApertureParameters(x_limits=[-0.1, 0.1]), + ApertureP=pals.ApertureParameters(shape="VERTICES"), ) # Solenoid @@ -247,7 +248,7 @@ def test_comprehensive_lattice(tmp_path): # Test that parameter groups are correctly deserialized assert sextupole_loaded.MagneticMultipoleP.Bn2 == 1.0 - assert sextupole_loaded.ApertureP.x_limits == [-0.1, 0.1] + assert sextupole_loaded.ApertureP.vertices.list[1].point == (0.1, 0) assert octupole_loaded.ElectricMultipoleP.En3 == 0.5 assert octupole_loaded.MetaP.alias == "octupole_test" From 94a6d77a9e8c17bae1e2d4a5b55b57deba29bbe7 Mon Sep 17 00:00:00 2001 From: Daniel Date: Sat, 21 Nov 2026 00:21:47 +0100 Subject: [PATCH 2/3] readded breaking 'vertices' to test --- tests/test_serialization.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/test_serialization.py b/tests/test_serialization.py index e4e1741..e184a67 100644 --- a/tests/test_serialization.py +++ b/tests/test_serialization.py @@ -148,7 +148,10 @@ def test_comprehensive_lattice(tmp_path): name="sextupole1", length=0.2, MagneticMultipoleP=pals.MagneticMultipoleParameters(Bn2=1.0), - ApertureP=pals.ApertureParameters(shape="VERTICES"), + ApertureP=pals.ApertureParameters( + shape="VERTICES", + vertices=Vertices( + list=[Vertex(point=(-0.1, 0), radius=0.1), Vertex(point=(0.1, 0))])), ) # Solenoid From 6c8018b0ca2bc7fa4c5d595b64730034aafeae08 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 20 Nov 2026 23:22:57 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- tests/test_serialization.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test_serialization.py b/tests/test_serialization.py index e184a67..37fd943 100644 --- a/tests/test_serialization.py +++ b/tests/test_serialization.py @@ -151,7 +151,9 @@ def test_comprehensive_lattice(tmp_path): ApertureP=pals.ApertureParameters( shape="VERTICES", vertices=Vertices( - list=[Vertex(point=(-0.1, 0), radius=0.1), Vertex(point=(0.1, 0))])), + list=[Vertex(point=(-0.1, 0), radius=0.1), Vertex(point=(0.1, 0))] + ), + ), ) # Solenoid