[SP-333] Fix error when comparing datetimes

waltaro · waltaro · commit ba42aed7a33c · 2019-09-30T13:59:45.000+10:00
diff --git a/rdl/data_sources/AWSLambdaDataSource.py b/rdl/data_sources/AWSLambdaDataSource.py
@@ -191,7 +191,8 @@ def __get_aws_client(self, service, credentials):
         )
 
     def __refresh_aws_clients_if_expired(self):
-        current_datetime = datetime.datetime.now()
+        # this is due to AWS returning their expiry date in UTC
+        current_datetime = datetime.datetime.now(datetime.timezone.utc)
 
         if (
             current_datetime > self.role_session_expiry - datetime.timedelta(minutes=5)

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,8 @@ def __get_aws_client(self, service, credentials):`
`191`	`191`	`)`
`192`	`192`
`193`	`193`	`def __refresh_aws_clients_if_expired(self):`
`194`		`- current_datetime = datetime.datetime.now()`
	`194`	`+ # this is due to AWS returning their expiry date in UTC`
	`195`	`+ current_datetime = datetime.datetime.now(datetime.timezone.utc)`
`195`	`196`
`196`	`197`	`if (`
`197`	`198`	`current_datetime > self.role_session_expiry - datetime.timedelta(minutes=5)`