SP-149 - bug fix - log at least 1 second as execution time per model/execution

Author: ChintanRaval

rdl/data_load_tracking/DataLoadTrackerRepository.py

@@ -42,7 +42,7 @@ def complete_execution(self, execution_id, total_number_of_models,
             .one()
 
         execution_end_time = session.query(func.now()).scalar()
-        total_execution_seconds = (execution_end_time - current_execution.started_on).total_seconds()
+        total_execution_seconds = max((execution_end_time - current_execution.started_on).total_seconds(), 1)
         total_rows_processed = self.get_execution_rows(current_execution.execution_id)
         total_batches_processed = self.get_execution_batches(current_execution.execution_id)
 
@@ -82,7 +82,7 @@ def save_execution_model(self, data_load_tracker):
             .one()
 
         execution_end_time = session.query(func.now()).scalar()
-        total_execution_seconds = (execution_end_time - current_execution_model.started_on).total_seconds()
+        total_execution_seconds = max((execution_end_time - current_execution_model.started_on).total_seconds(), 1)
 
         current_execution_model.completed_on = execution_end_time
         current_execution_model.execution_time_ms = int(total_execution_seconds * 1000)

rdl/entities/execution_entity.py

@@ -49,9 +49,9 @@ def __str__(self):
                 exec_id=self.execution_id,
                 status=self.status,
                 started=self.started_on.isoformat(),
-                completed=self.completed_on.isoformat() if self.completed_on else '',
-                exec_time=execution_time_str if execution_time_str else '',
-                models=f'{self.models_processed:,}' if self.models_processed else '',
-                batches=f'{self.batches_processed:,}' if self.batches_processed else '',
-                rows=f'{self.rows_processed:,}' if self.rows_processed else '',
-                rows_per_second=f'{rows_per_second:,.2f}' if rows_per_second else '')
+                completed=self.completed_on.isoformat() if self.completed_on else 'n/a',
+                exec_time=execution_time_str if execution_time_str else 'n/a',
+                models=f'{self.models_processed:,}' if self.models_processed else 'n/a',
+                batches=f'{self.batches_processed:,}' if self.batches_processed else 'n/a',
+                rows=f'{self.rows_processed:,}' if self.rows_processed else 'n/a',
+                rows_per_second=f'{rows_per_second:,.2f}' if rows_per_second else 'n/a')

rdl/entities/execution_model_entity.py

@@ -60,8 +60,8 @@ def __str__(self):
                 load_type=load_type,
                 status=self.status,
                 started=self.started_on.isoformat(),
-                completed=self.completed_on.isoformat() if self.completed_on else '',
-                exec_time=f'{execution_time_s}s' if execution_time_s else '',
-                batches=f'{self.batches_processed:,}' if self.batches_processed else '',
-                rows=f'{self.rows_processed:,}' if self.rows_processed else '',
-                rows_per_second=f'{rows_per_second:,.2f}' if rows_per_second else '')
+                completed=self.completed_on.isoformat() if self.completed_on else 'n/a',
+                exec_time=f'{execution_time_s}s' if execution_time_s else 'n/a',
+                batches=f'{self.batches_processed:,}' if self.batches_processed else 'n/a',
+                rows=f'{self.rows_processed:,}' if self.rows_processed else 'n/a',
+                rows_per_second=f'{rows_per_second:,.2f}' if rows_per_second else 'n/a')