Skip to content
This repository was archived by the owner on Mar 13, 2020. It is now read-only.

Commit 363b554

Browse files
committed
nested change tracking info inside source table info to avoid having to restructure it's usages
1 parent e2cb927 commit 363b554

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

rdl/data_sources/MsSqlDataSource.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def __build_select_statement(self, table_config, columns, batch_config, batch_ke
115115
def get_table_info(self, table_config, last_known_sync_version):
116116
columns_in_database = self.__get_table_columns(table_config)
117117
change_tracking_info = self.__get_change_tracking_info(table_config, last_known_sync_version)
118-
source_table_info = SourceTableInfo.from_change_tracking_info(columns_in_database, change_tracking_info)
118+
source_table_info = SourceTableInfo(columns_in_database, change_tracking_info)
119119
return source_table_info
120120

121121
def __get_table_columns(self, table_config):

rdl/data_sources/SourceTableInfo.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,6 @@
22

33

44
class SourceTableInfo:
5-
def __init__(self, column_names: [],
6-
last_sync_version: str, sync_version: str,
7-
force_full_load: str, data_changed_since_last_sync: str):
5+
def __init__(self, column_names: [], change_tracking_info: ChangeTrackingInfo):
86
self.column_names = column_names
9-
self.last_sync_version = last_sync_version
10-
self.sync_version = sync_version
11-
self.force_full_load = force_full_load
12-
self.data_changed_since_last_sync = data_changed_since_last_sync
13-
14-
@classmethod
15-
def from_change_tracking_info(cls, column_names: [], change_tracking_info: ChangeTrackingInfo):
16-
return cls(column_names,
17-
change_tracking_info.last_sync_version, change_tracking_info.sync_version,
18-
change_tracking_info.force_full_load, change_tracking_info.data_changed_since_last_sync)
7+
self.change_tracking_info = change_tracking_info

0 commit comments

Comments
 (0)