add tests for editor launch and dialog improvements

Add comprehensive test coverage for the wait_for_completion functionality and InfoDialogKind enum variants. Tests verify proper handling of successful editor launches, exit status reporting, and missing command detection in both background and blocking modes.

Author: ozankasikci

src/commands/interactive/dialog.rs

@@ -542,3 +542,47 @@ pub(crate) enum Dialog {
     Create(CreateDialog),
     Merge(MergeDialog),
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn dialog_info_with_info_kind() {
+        let dialog = Dialog::Info {
+            message: "Test message".to_string(),
+            kind: InfoDialogKind::Info,
+        };
+
+        match dialog {
+            Dialog::Info { message, kind } => {
+                assert_eq!(message, "Test message");
+                assert!(matches!(kind, InfoDialogKind::Info));
+            }
+            _ => panic!("Expected Info dialog"),
+        }
+    }
+
+    #[test]
+    fn dialog_info_with_error_kind() {
+        let dialog = Dialog::Info {
+            message: "Error message".to_string(),
+            kind: InfoDialogKind::Error,
+        };
+
+        match dialog {
+            Dialog::Info { message, kind } => {
+                assert_eq!(message, "Error message");
+                assert!(matches!(kind, InfoDialogKind::Error));
+            }
+            _ => panic!("Expected Info dialog"),
+        }
+    }
+
+    #[test]
+    fn info_dialog_kind_is_copy() {
+        let kind = InfoDialogKind::Info;
+        let _copy = kind;
+        let _another_copy = kind; // Should compile due to Copy trait
+    }
+}

src/editor/launch.rs

@@ -160,4 +160,69 @@ mod tests {
         let outcome = launch_editor(request);
         assert_eq!(outcome.status, EditorLaunchStatus::EditorMissing);
     }
+
+    #[test]
+    fn wait_for_completion_succeeds_with_valid_command() {
+        let dir = TempDir::new().expect("tempdir");
+        let worktree_path = dir.path();
+        let request = LaunchRequest {
+            preference: &EditorPreference {
+                command: OsString::from("true"),
+                args: Vec::new(),
+                source: crate::editor::EditorPreferenceSource::Environment {
+                    variable: crate::editor::EditorEnvVar::Editor,
+                },
+            },
+            worktree_name: "feature",
+            worktree_path,
+            wait_for_completion: true,
+        };
+
+        let outcome = launch_editor(request);
+        assert_eq!(outcome.status, EditorLaunchStatus::Success);
+    }
+
+    #[test]
+    fn wait_for_completion_reports_exit_status() {
+        let dir = TempDir::new().expect("tempdir");
+        let worktree_path = dir.path();
+        let request = LaunchRequest {
+            preference: &EditorPreference {
+                command: OsString::from("false"),
+                args: Vec::new(),
+                source: crate::editor::EditorPreferenceSource::Environment {
+                    variable: crate::editor::EditorEnvVar::Editor,
+                },
+            },
+            worktree_name: "feature",
+            worktree_path,
+            wait_for_completion: true,
+        };
+
+        let outcome = launch_editor(request);
+        assert_eq!(outcome.status, EditorLaunchStatus::SpawnError);
+        assert!(outcome.message.contains("exited with status"));
+    }
+
+    #[test]
+    fn wait_for_completion_reports_missing_command() {
+        let dir = TempDir::new().expect("tempdir");
+        let worktree_path = dir.path();
+        let request = LaunchRequest {
+            preference: &EditorPreference {
+                command: OsString::from("unlikely-editor-command"),
+                args: Vec::new(),
+                source: crate::editor::EditorPreferenceSource::Environment {
+                    variable: crate::editor::EditorEnvVar::Editor,
+                },
+            },
+            worktree_name: "feature",
+            worktree_path,
+            wait_for_completion: true,
+        };
+
+        let outcome = launch_editor(request);
+        assert_eq!(outcome.status, EditorLaunchStatus::EditorMissing);
+        assert!(outcome.message.contains("was not found on PATH"));
+    }
 }